Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.cpp
diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp
index 6b58eb430417d009ca5569b0c701b265a1a73bdf..964782671710f69e392a15a16806a1f7785f728d 100644
--- a/third_party/WebKit/Source/core/editing/Position.cpp
+++ b/third_party/WebKit/Source/core/editing/Position.cpp
@@ -490,10 +490,10 @@ int PositionTemplate<Strategy>::LastOffsetInNode(Node* node) {
// static
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::FirstPositionInNode(
- Node* anchor_node) {
- if (anchor_node->IsTextNode())
+ const Node& anchor_node) {
+ if (anchor_node.IsTextNode())
return PositionTemplate<Strategy>(anchor_node, 0);
- return PositionTemplate<Strategy>(anchor_node,
+ return PositionTemplate<Strategy>(&anchor_node,
PositionAnchorType::kBeforeChildren);
}
@@ -515,7 +515,7 @@ PositionTemplate<Strategy>::FirstPositionInOrBeforeNode(Node* node) {
if (!node)
return PositionTemplate<Strategy>();
return EditingIgnoresContent(*node) ? BeforeNode(*node)
- : FirstPositionInNode(node);
+ : FirstPositionInNode(*node);
}
// static
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.h ('k') | third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698