third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Unified Diff: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/PositionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

index 615d2aea52b2f82e25da7b773e68715acd9963f6..b609a0296fbabf7c4ec309a15604577ab8e48efb 100644

--- a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

+++ b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

@@ -141,7 +141,7 @@ TEST_F(PositionIteratorTest, incrementWithInputElement) {

// Increment until start of "123" from INPUT on DOM tree

PositionIterator dom_iterator(

- Position::FirstPositionInNode(GetDocument().body()));

+ Position::FirstPositionInNode(*GetDocument().body()));

EXPECT_EQ(Position(GetDocument().body(), 0), dom_iterator.ComputePosition());

dom_iterator.Increment();

EXPECT_EQ(Position::BeforeNode(*input), dom_iterator.ComputePosition());

@@ -154,7 +154,7 @@ TEST_F(PositionIteratorTest, incrementWithInputElement) {

// Increment until start of "123" from INPUT on flat tree

PositionIteratorInFlatTree flat_iterator(

- PositionInFlatTree::FirstPositionInNode(GetDocument().body()));

+ PositionInFlatTree::FirstPositionInNode(*GetDocument().body()));

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 0),

flat_iterator.ComputePosition());

flat_iterator.Increment();

@@ -177,7 +177,7 @@ TEST_F(PositionIteratorTest, incrementWithSelectElement) {

// Increment until start of "123" from SELECT on DOM tree

PositionIterator dom_iterator(

- Position::FirstPositionInNode(GetDocument().body()));

+ Position::FirstPositionInNode(*GetDocument().body()));

EXPECT_EQ(Position(GetDocument().body(), 0), dom_iterator.ComputePosition());

dom_iterator.Increment();

EXPECT_EQ(Position::BeforeNode(*select), dom_iterator.ComputePosition());

@@ -194,7 +194,7 @@ TEST_F(PositionIteratorTest, incrementWithSelectElement) {

// Increment until start of "123" from SELECT on flat tree

PositionIteratorInFlatTree flat_iterator(

- PositionInFlatTree::FirstPositionInNode(GetDocument().body()));

+ PositionInFlatTree::FirstPositionInNode(*GetDocument().body()));

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 0),

flat_iterator.ComputePosition());

flat_iterator.Increment();

@@ -223,7 +223,7 @@ TEST_F(PositionIteratorTest, incrementWithTextAreaElement) {

// Increment until start of "123" from TEXTAREA on DOM tree

PositionIterator dom_iterator(

- Position::FirstPositionInNode(GetDocument().body()));

+ Position::FirstPositionInNode(*GetDocument().body()));

EXPECT_EQ(Position(GetDocument().body(), 0), dom_iterator.ComputePosition());

dom_iterator.Increment();

EXPECT_EQ(Position::BeforeNode(*textarea), dom_iterator.ComputePosition());

@@ -236,7 +236,7 @@ TEST_F(PositionIteratorTest, incrementWithTextAreaElement) {

// Increment until start of "123" from TEXTAREA on flat tree

PositionIteratorInFlatTree flat_iterator(

- PositionInFlatTree::FirstPositionInNode(GetDocument().body()));

+ PositionInFlatTree::FirstPositionInNode(*GetDocument().body()));

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 0),

flat_iterator.ComputePosition());

// TODO(yosin): We should not traverse inside TEXTAREA

« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/PositionTest.cpp » ('j') | no next file with comments »