third_party/WebKit/Source/core/editing/Position.h - Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Position.h

diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h

index 11ed856bb9635eb10a620086bf7d73aa66e4a827..0e97aae3791ae9f564ca65b30bbc5b0b3cdf3fb2 100644

--- a/third_party/WebKit/Source/core/editing/Position.h

+++ b/third_party/WebKit/Source/core/editing/Position.h

@@ -193,7 +193,8 @@ class CORE_TEMPLATE_CLASS_EXPORT PositionTemplate {

static PositionTemplate<Strategy> InParentBeforeNode(const Node& anchor_node);

static PositionTemplate<Strategy> InParentAfterNode(const Node& anchor_node);

static int LastOffsetInNode(Node* anchor_node);

- static PositionTemplate<Strategy> FirstPositionInNode(Node* anchor_node);

+ static PositionTemplate<Strategy> FirstPositionInNode(

+ const Node& anchor_node);

static PositionTemplate<Strategy> LastPositionInNode(Node* anchor_node);

static PositionTemplate<Strategy> FirstPositionInOrBeforeNode(

Node* anchor_node);