Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
index eb00000a420fdb9606989cb27239323de19149a1..aeae25413d2ab891185b7869502b026cf4dd93b5 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
@@ -55,7 +55,7 @@ TEST_F(EditingUtilitiesTest, firstEditablePositionAfterPositionInRoot) {
.DeepEquivalent());
EXPECT_EQ(
- Position::FirstPositionInNode(host),
+ Position::FirstPositionInNode(*host),
FirstEditablePositionAfterPositionInRoot(Position(three, 0), *host));
EXPECT_EQ(
Position(one->firstChild(), 0),
@@ -184,13 +184,13 @@ TEST_F(EditingUtilitiesTest, lastEditablePositionBeforePositionInRoot) {
.DeepEquivalent());
EXPECT_EQ(
- Position::FirstPositionInNode(host),
+ Position::FirstPositionInNode(*host),
LastEditablePositionBeforePositionInRoot(Position(three, 0), *host));
EXPECT_EQ(
Position(one->firstChild(), 0),
LastEditableVisiblePositionBeforePositionInRoot(Position(three, 0), *host)
.DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree::FirstPositionInNode(host),
+ EXPECT_EQ(PositionInFlatTree::FirstPositionInNode(*host),
LastEditablePositionBeforePositionInRoot(
PositionInFlatTree(three, 0), *host));
EXPECT_EQ(PositionInFlatTree(two->firstChild(), 0),
« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | third_party/WebKit/Source/core/editing/EphemeralRange.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698