Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/editing/EditingUtilities.h" 5 #include "core/editing/EditingUtilities.h"
6 6
7 #include "core/dom/StaticNodeList.h" 7 #include "core/dom/StaticNodeList.h"
8 #include "core/editing/EditingTestBase.h" 8 #include "core/editing/EditingTestBase.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 EXPECT_EQ(PositionInFlatTree(one, 0), 49 EXPECT_EQ(PositionInFlatTree(one, 0),
50 FirstEditablePositionAfterPositionInRoot(PositionInFlatTree(one, 0), 50 FirstEditablePositionAfterPositionInRoot(PositionInFlatTree(one, 0),
51 *host)); 51 *host));
52 EXPECT_EQ(PositionInFlatTree(two->firstChild(), 2), 52 EXPECT_EQ(PositionInFlatTree(two->firstChild(), 2),
53 FirstEditableVisiblePositionAfterPositionInRoot( 53 FirstEditableVisiblePositionAfterPositionInRoot(
54 PositionInFlatTree(one, 0), *host) 54 PositionInFlatTree(one, 0), *host)
55 .DeepEquivalent()); 55 .DeepEquivalent());
56 56
57 EXPECT_EQ( 57 EXPECT_EQ(
58 Position::FirstPositionInNode(host), 58 Position::FirstPositionInNode(*host),
59 FirstEditablePositionAfterPositionInRoot(Position(three, 0), *host)); 59 FirstEditablePositionAfterPositionInRoot(Position(three, 0), *host));
60 EXPECT_EQ( 60 EXPECT_EQ(
61 Position(one->firstChild(), 0), 61 Position(one->firstChild(), 0),
62 FirstEditableVisiblePositionAfterPositionInRoot(Position(three, 0), *host) 62 FirstEditableVisiblePositionAfterPositionInRoot(Position(three, 0), *host)
63 .DeepEquivalent()); 63 .DeepEquivalent());
64 EXPECT_EQ(PositionInFlatTree::AfterNode(*host), 64 EXPECT_EQ(PositionInFlatTree::AfterNode(*host),
65 FirstEditablePositionAfterPositionInRoot( 65 FirstEditablePositionAfterPositionInRoot(
66 PositionInFlatTree(three, 0), *host)); 66 PositionInFlatTree(three, 0), *host));
67 EXPECT_EQ(PositionInFlatTree::LastPositionInNode(host), 67 EXPECT_EQ(PositionInFlatTree::LastPositionInNode(host),
68 FirstEditableVisiblePositionAfterPositionInRoot( 68 FirstEditableVisiblePositionAfterPositionInRoot(
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 177
178 EXPECT_EQ(PositionInFlatTree(one, 0), 178 EXPECT_EQ(PositionInFlatTree(one, 0),
179 LastEditablePositionBeforePositionInRoot(PositionInFlatTree(one, 0), 179 LastEditablePositionBeforePositionInRoot(PositionInFlatTree(one, 0),
180 *host)); 180 *host));
181 EXPECT_EQ(PositionInFlatTree(two->firstChild(), 2), 181 EXPECT_EQ(PositionInFlatTree(two->firstChild(), 2),
182 LastEditableVisiblePositionBeforePositionInRoot( 182 LastEditableVisiblePositionBeforePositionInRoot(
183 PositionInFlatTree(one, 0), *host) 183 PositionInFlatTree(one, 0), *host)
184 .DeepEquivalent()); 184 .DeepEquivalent());
185 185
186 EXPECT_EQ( 186 EXPECT_EQ(
187 Position::FirstPositionInNode(host), 187 Position::FirstPositionInNode(*host),
188 LastEditablePositionBeforePositionInRoot(Position(three, 0), *host)); 188 LastEditablePositionBeforePositionInRoot(Position(three, 0), *host));
189 EXPECT_EQ( 189 EXPECT_EQ(
190 Position(one->firstChild(), 0), 190 Position(one->firstChild(), 0),
191 LastEditableVisiblePositionBeforePositionInRoot(Position(three, 0), *host) 191 LastEditableVisiblePositionBeforePositionInRoot(Position(three, 0), *host)
192 .DeepEquivalent()); 192 .DeepEquivalent());
193 EXPECT_EQ(PositionInFlatTree::FirstPositionInNode(host), 193 EXPECT_EQ(PositionInFlatTree::FirstPositionInNode(*host),
194 LastEditablePositionBeforePositionInRoot( 194 LastEditablePositionBeforePositionInRoot(
195 PositionInFlatTree(three, 0), *host)); 195 PositionInFlatTree(three, 0), *host));
196 EXPECT_EQ(PositionInFlatTree(two->firstChild(), 0), 196 EXPECT_EQ(PositionInFlatTree(two->firstChild(), 0),
197 LastEditableVisiblePositionBeforePositionInRoot( 197 LastEditableVisiblePositionBeforePositionInRoot(
198 PositionInFlatTree(three, 0), *host) 198 PositionInFlatTree(three, 0), *host)
199 .DeepEquivalent()); 199 .DeepEquivalent());
200 } 200 }
201 201
202 TEST_F(EditingUtilitiesTest, NextNodeIndex) { 202 TEST_F(EditingUtilitiesTest, NextNodeIndex) {
203 const char* body_content = 203 const char* body_content =
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 PositionMoveType::kBackwardDeletion)); 899 PositionMoveType::kBackwardDeletion));
900 EXPECT_EQ(Position(node, 2), 900 EXPECT_EQ(Position(node, 2),
901 PreviousPositionOf(Position(node, 3), 901 PreviousPositionOf(Position(node, 3),
902 PositionMoveType::kBackwardDeletion)); 902 PositionMoveType::kBackwardDeletion));
903 EXPECT_EQ(Position(node, 0), 903 EXPECT_EQ(Position(node, 0),
904 PreviousPositionOf(Position(node, 1), 904 PreviousPositionOf(Position(node, 1),
905 PositionMoveType::kBackwardDeletion)); 905 PositionMoveType::kBackwardDeletion));
906 } 906 }
907 907
908 } // namespace blink 908 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | third_party/WebKit/Source/core/editing/EphemeralRange.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698