Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2952983002: Make Position::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-23T10:37:43 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index 595aebbcbb9257028cb04d8d3d1972d57fd451ab..b790cb07d2ffab7347cc10d273e40d9575ce020d 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -655,9 +655,9 @@ PositionTemplate<Strategy> FirstEditablePositionAfterPositionInRootAlgorithm(
<< position << ' ' << highest_root;
// position falls before highestRoot.
if (position.CompareTo(PositionTemplate<Strategy>::FirstPositionInNode(
- &highest_root)) == -1 &&
+ highest_root)) == -1 &&
HasEditableStyle(highest_root))
- return PositionTemplate<Strategy>::FirstPositionInNode(&highest_root);
+ return PositionTemplate<Strategy>::FirstPositionInNode(highest_root);
PositionTemplate<Strategy> editable_position = position;
@@ -1907,7 +1907,7 @@ int IndexForVisiblePosition(const VisiblePosition& visible_position,
else
scope = document.documentElement();
- EphemeralRange range(Position::FirstPositionInNode(scope),
+ EphemeralRange range(Position::FirstPositionInNode(*scope),
p.ParentAnchoredEquivalent());
return TextIterator::RangeLength(
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698