Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2961893002: Reverse true/false states of load_time_data_defaults_added_. (Closed)

Created:
3 years, 5 months ago by michaeldo
Modified:
3 years, 5 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reverse true/false states of load_time_data_defaults_added_. The flag should start false and then become true once the defaults are added the first time in order to match the logic implied by the name of the flag. BUG=734079 Review-Url: https://codereview.chromium.org/2961893002 Cr-Commit-Position: refs/heads/master@{#482777} Committed: https://chromium.googlesource.com/chromium/src/+/fbb098ec7352049bd4826bf67c46a9183b567e62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ios/web/webui/web_ui_ios_data_source_impl.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaeldo
3 years, 5 months ago (2017-06-27 21:23:53 UTC) #2
dschuyler
lgtm
3 years, 5 months ago (2017-06-27 21:38:23 UTC) #4
Eugene But (OOO till 7-30)
lgtm
3 years, 5 months ago (2017-06-27 21:40:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961893002/1
3 years, 5 months ago (2017-06-27 21:49:42 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 22:54:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbb098ec7352049bd4826bf67c46...

Powered by Google App Engine
This is Rietveld 408576698