Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout object

Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout object

This is follow-up patch of the patch[1] which introduces |InSameLine()| to
return wrong value for nodes without layout object.

Original code:
while (node && !node->GetLayoutObject() || InSameLine(...)

The patch[1]:

while (InSameLine(node, ...)

InSameLine(Node* node)
  if (!node->GetLayoutObject())
    return false;  // This is wrong. This patch fixes this error.

[1] http://crrev.com/2938923003: Introduce InSameLine() with Node and
VisiblePosition

BUG=734648
TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone

Review-Url: https://codereview.chromium.org/2952563002
Cr-Commit-Position: refs/heads/master@{#481057}
Committed: https://chromium.googlesource.com/chromium/src/+/5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116

[yosin_UTC9, 2017-06-20 09:41:15]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 09:41:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-20 09:43:26]

Description was changed from

==========
2017-06-20T18:32:46

BUG=

2017-06-20T18:32:03
==========

to

==========
Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout
object

This is follow-up patch of the patch[1] which introduces |InSameLine()| to
return wrong value for nodes without layout object.

Original code:
while (node && !node->GetLayoutObject() || InSameLine(...)

The patch[1]:

while (InSameLine(node, ...)

InSameLine(Node* node)
  if (!node->GetLayoutObject())
    return false;  // This is wrong. This patch fixes this error.

[1] http://crrev.com/2938923003: Introduce InSameLine() with Node and
VisiblePosition

BUG=734648
TEST=run_webkit_unit_tests
--gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone
==========

[yosin_UTC9, 2017-06-20 09:43:42]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-20 09:43:43]

PTAL

[commit-bot: I haz the power, 2017-06-20 11:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 11:56:28]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-20 18:19:52]

lgtm. Thanks!

It's fortunate that performance bots caught our mistake...

[yosin_UTC9, 2017-06-21 01:07:14]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-21 01:07:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 01:12:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498007234921370, "parent_rev":
"59326d74274f028a233a2561f940a84675e0c967", "commit_rev":
"5bdfdfb6bb8fa7593b2d4f81f1304c14f248a116"}

[commit-bot: I haz the power, 2017-06-21 01:12:55]

Description was changed from

==========
Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout
object

This is follow-up patch of the patch[1] which introduces |InSameLine()| to
return wrong value for nodes without layout object.

Original code:
while (node && !node->GetLayoutObject() || InSameLine(...)

The patch[1]:

while (InSameLine(node, ...)

InSameLine(Node* node)
  if (!node->GetLayoutObject())
    return false;  // This is wrong. This patch fixes this error.

[1] http://crrev.com/2938923003: Introduce InSameLine() with Node and
VisiblePosition

BUG=734648
TEST=run_webkit_unit_tests
--gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone
==========

to

==========
Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout
object

This is follow-up patch of the patch[1] which introduces |InSameLine()| to
return wrong value for nodes without layout object.

Original code:
while (node && !node->GetLayoutObject() || InSameLine(...)

The patch[1]:

while (InSameLine(node, ...)

InSameLine(Node* node)
  if (!node->GetLayoutObject())
    return false;  // This is wrong. This patch fixes this error.

[1] http://crrev.com/2938923003: Introduce InSameLine() with Node and
VisiblePosition

BUG=734648
TEST=run_webkit_unit_tests
--gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone

Review-Url: https://codereview.chromium.org/2952563002
Cr-Commit-Position: refs/heads/master@{#481057}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bdfdfb6bb8fa7593b2d4f81f130...
==========

[commit-bot: I haz the power, 2017-06-21 01:12:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bdfdfb6bb8fa7593b2d4f81f130...