third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp - Issue 2952563002: Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

Issue 2952563002: Make PreviousRootInlineBoxCandidatePosition() to ignore nodes without layout object (Closed)

Patch Set: 2017-06-20T18:32:03 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

index 5a820f3f7bada9f6d75ba5b4cbc51b38198f7dd7..f399e1f5b2d172bdbf66f0521df4e418dc006352 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

@@ -253,7 +253,7 @@ LayoutPoint AbsoluteLineDirectionPointToLocalPointInBlock(

bool InSameLine(const Node& node, const VisiblePosition& visible_position) {

if (!node.GetLayoutObject())

- return false;

+ return true;

return InSameLine(CreateVisiblePosition(

FirstPositionInOrBeforeNode(const_cast<Node*>(&node))),

visible_position);