Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2952403002: [ObjC ARC] Converts ios/chrome/browser/translate:translate to ARC. (Closed)

Created:
3 years, 6 months ago by stkhapugin
Modified:
3 years, 5 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/translate:translate to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2952403002 Cr-Commit-Position: refs/heads/master@{#482242} Committed: https://chromium.googlesource.com/chromium/src/+/ae66e1500289ce8998eea4022dfbca38d874a4a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -65 lines) Patch
M ios/chrome/browser/translate/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/translate/after_translate_infobar_controller.mm View 5 chunks +10 lines, -7 lines 0 comments Download
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 13 chunks +39 lines, -39 lines 0 comments Download
M ios/chrome/browser/translate/chrome_ios_translate_client.mm View 2 chunks +13 lines, -9 lines 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 4 chunks +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/translate/translate_message_infobar_controller.mm View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
stkhapugin
PTAL
3 years, 6 months ago (2017-06-23 16:19:44 UTC) #4
marq (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-23 17:07:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952403002/1
3 years, 5 months ago (2017-06-26 10:05:26 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 11:31:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae66e1500289ce8998eea4022dfb...

Powered by Google App Engine
This is Rietveld 408576698