Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: ios/chrome/browser/translate/chrome_ios_translate_client.mm

Issue 2952403002: [ObjC ARC] Converts ios/chrome/browser/translate:translate to ARC. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/translate/chrome_ios_translate_client.mm
diff --git a/ios/chrome/browser/translate/chrome_ios_translate_client.mm b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
index 623ad385338a56335227d795f8efaa8e5e0f8688..d6b56413db63d204379ed8447f171f99ae9d4872 100644
--- a/ios/chrome/browser/translate/chrome_ios_translate_client.mm
+++ b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
@@ -37,6 +37,10 @@
#include "ios/web/public/web_state/web_state.h"
#include "url/gurl.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
DEFINE_WEB_STATE_USER_DATA_KEY(ChromeIOSTranslateClient);
ChromeIOSTranslateClient::ChromeIOSTranslateClient(web::WebState* web_state)
@@ -75,24 +79,24 @@ std::unique_ptr<infobars::InfoBar> ChromeIOSTranslateClient::CreateInfoBar(
translate::TranslateStep step = delegate->translate_step();
std::unique_ptr<InfoBarIOS> infobar(new InfoBarIOS(std::move(delegate)));
- base::scoped_nsobject<InfoBarController> controller;
+ InfoBarController* controller;
switch (step) {
case translate::TRANSLATE_STEP_AFTER_TRANSLATE:
- controller.reset([[AfterTranslateInfoBarController alloc]
- initWithDelegate:infobar.get()]);
+ controller = [[AfterTranslateInfoBarController alloc]
+ initWithDelegate:infobar.get()];
break;
case translate::TRANSLATE_STEP_BEFORE_TRANSLATE:
- controller.reset([[BeforeTranslateInfoBarController alloc]
- initWithDelegate:infobar.get()]);
+ controller = [[BeforeTranslateInfoBarController alloc]
+ initWithDelegate:infobar.get()];
break;
case translate::TRANSLATE_STEP_NEVER_TRANSLATE:
- controller.reset([[NeverTranslateInfoBarController alloc]
- initWithDelegate:infobar.get()]);
+ controller = [[NeverTranslateInfoBarController alloc]
+ initWithDelegate:infobar.get()];
break;
case translate::TRANSLATE_STEP_TRANSLATING:
case translate::TRANSLATE_STEP_TRANSLATE_ERROR:
- controller.reset([[TranslateMessageInfoBarController alloc]
- initWithDelegate:infobar.get()]);
+ controller = [[TranslateMessageInfoBarController alloc]
+ initWithDelegate:infobar.get()];
break;
default:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698