|
|
DescriptionAdd documentation in memory_benchmarks.md on finding links to trace files
This CL:
- incorporates the feedback (see linked bug) that
memory_benchmarks.md doesn't mention where to find the trace files on
perf dashboard.
- adds
"memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg"
string in a comment in url_request_context.h, so it's greppable in
code and makes it easier to find where the metric comes from.
BUG=734619
Review-Url: https://codereview.chromium.org/2952203002
Cr-Commit-Position: refs/heads/master@{#481871}
Committed: https://chromium.googlesource.com/chromium/src/+/0c0ed3be51e0487b4a210f8a77ff714358d9b95e
Patch Set 1 : self #
Total comments: 3
Messages
Total messages: 14 (8 generated)
Description was changed from ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ========== to ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (in the linked bug that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ==========
Description was changed from ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (in the linked bug that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ========== to ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (in the linked bug that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ==========
Description was changed from ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (in the linked bug that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ========== to ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (see linked bug) that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ==========
Patchset #1 (id:1) has been deleted
xunjieli@chromium.org changed reviewers: + mmenke@chromium.org, primiano@chromium.org
primiano@ and mmenke@: PTAL. Thank you. https://codereview.chromium.org/2952203002/diff/20001/docs/memory-infra/memor... File docs/memory-infra/memory_benchmarks.md (right): https://codereview.chromium.org/2952203002/diff/20001/docs/memory-infra/memor... docs/memory-infra/memory_benchmarks.md:99: ![Chrome Performance Dashboard Alert](https://storage.googleapis.com/chromium-docs.appspot.com/perfdashboard_alert.png) Primiano: should I rename the filename to contain a hash of some sort to be consistent with the naming convention? How did you do it? The gsutil directory seems to have files named after hashes. current files are: gs://chromium-docs.appspot.com/79d08f59cf497c761f7099ea427704c14e9afc03.png gs://chromium-docs.appspot.com/802141906869cd533bb613da5f91bd0b071ceb24 gs://chromium-docs.appspot.com/a24d80d6a08da088e2e9c8b2b64daa215be4dacb gs://chromium-docs.appspot.com/a325c4426422e53394a322d31b652cfa34231189 gs://chromium-docs.appspot.com/a73239c6367ed0f844500e51ce1e04556cb99b4f.png gs://chromium-docs.appspot.com/ea60207d9bb4809178fe75923d6d1a2b241170ef.png gs://chromium-docs.appspot.com/ec61c5f15705f5bcf3ca83a155ed647a0538bbe1
LGTM, thanks!
thanks a lot. lgtm https://codereview.chromium.org/2952203002/diff/20001/docs/memory-infra/memor... File docs/memory-infra/memory_benchmarks.md (right): https://codereview.chromium.org/2952203002/diff/20001/docs/memory-infra/memor... docs/memory-infra/memory_benchmarks.md:99: ![Chrome Performance Dashboard Alert](https://storage.googleapis.com/chromium-docs.appspot.com/perfdashboard_alert.png) On 2017/06/22 15:55:14, xunjieli wrote: > Primiano: should I rename the filename to contain a hash of some sort to be > consistent with the naming convention? How did you do it? > > The gsutil directory seems to have files named after hashes. > current files are: > gs://chromium-docs.appspot.com/79d08f59cf497c761f7099ea427704c14e9afc03.png > gs://chromium-docs.appspot.com/802141906869cd533bb613da5f91bd0b071ceb24 > gs://chromium-docs.appspot.com/a24d80d6a08da088e2e9c8b2b64daa215be4dacb > gs://chromium-docs.appspot.com/a325c4426422e53394a322d31b652cfa34231189 > gs://chromium-docs.appspot.com/a73239c6367ed0f844500e51ce1e04556cb99b4f.png > gs://chromium-docs.appspot.com/ea60207d9bb4809178fe75923d6d1a2b241170ef.png > gs://chromium-docs.appspot.com/ec61c5f15705f5bcf3ca83a155ed647a0538bbe1 Doesn't really matter. I think those hashes came from using upload_to_google_storage (part of depot tools). But if you managed to upload stuff manually with just gsutil works anyways :)
https://codereview.chromium.org/2952203002/diff/20001/docs/memory-infra/memor... File docs/memory-infra/memory_benchmarks.md (right): https://codereview.chromium.org/2952203002/diff/20001/docs/memory-infra/memor... docs/memory-infra/memory_benchmarks.md:99: ![Chrome Performance Dashboard Alert](https://storage.googleapis.com/chromium-docs.appspot.com/perfdashboard_alert.png) On 2017/06/23 08:53:41, Primiano Tucci wrote: > On 2017/06/22 15:55:14, xunjieli wrote: > > Primiano: should I rename the filename to contain a hash of some sort to be > > consistent with the naming convention? How did you do it? > > > > The gsutil directory seems to have files named after hashes. > > current files are: > > gs://chromium-docs.appspot.com/79d08f59cf497c761f7099ea427704c14e9afc03.png > > gs://chromium-docs.appspot.com/802141906869cd533bb613da5f91bd0b071ceb24 > > gs://chromium-docs.appspot.com/a24d80d6a08da088e2e9c8b2b64daa215be4dacb > > gs://chromium-docs.appspot.com/a325c4426422e53394a322d31b652cfa34231189 > > gs://chromium-docs.appspot.com/a73239c6367ed0f844500e51ce1e04556cb99b4f.png > > gs://chromium-docs.appspot.com/ea60207d9bb4809178fe75923d6d1a2b241170ef.png > > gs://chromium-docs.appspot.com/ec61c5f15705f5bcf3ca83a155ed647a0538bbe1 > > Doesn't really matter. I think those hashes came from using > upload_to_google_storage (part of depot tools). But if you managed to upload > stuff manually with just gsutil works anyways :) Acknowledged. Got it. Thank you.
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498222291951080, "parent_rev": "1dfa01ea4e491235842f2d60694ade684c52b069", "commit_rev": "0c0ed3be51e0487b4a210f8a77ff714358d9b95e"}
Message was sent while issue was closed.
Description was changed from ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (see linked bug) that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 ========== to ========== Add documentation in memory_benchmarks.md on finding links to trace files This CL: - incorporates the feedback (see linked bug) that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 Review-Url: https://codereview.chromium.org/2952203002 Cr-Commit-Position: refs/heads/master@{#481871} Committed: https://chromium.googlesource.com/chromium/src/+/0c0ed3be51e0487b4a210f8a77ff... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0c0ed3be51e0487b4a210f8a77ff... |