Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2952143002:
Disable NGLineBreakerTest.OverflowAtomicInline under ASan (Closed)
|
Created:
3 years, 6 months ago by kojii Modified:
3 years, 6 months ago CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable NGLineBreakerTest.OverflowAtomicInline under ASan
It leaks memory in CopyFragmentDataToLayoutBox. Disabling until
LayoutNGPaintFragments is ready. Same as issue 721932.
BUG=732574
R=hans@chromium.org, thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Review-Url: https://codereview.chromium.org/2952143002
Cr-Commit-Position: refs/heads/master@{#481519}
Committed: https://chromium.googlesource.com/chromium/src/+/fc930616af698875d2e6a2a955326c7910f4059a
Patch Set 1 : fix typo #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. BUG=732574 R=has@chromium.org, thakis@chromium.org ========== to ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. BUG=732574 R=has@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL.
Description was changed from ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. BUG=732574 R=has@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. Same as issue 721932. BUG=732574 R=has@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
Description was changed from ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. Same as issue 721932. BUG=732574 R=has@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. Same as issue 721932. BUG=732574 R=hans@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
kojii@chromium.org changed reviewers: + hans@chromium.org - has@chromium.org
has -> hans, sorry for the typo.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hans@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498139452713760,
"parent_rev": "7c51029f7f3e25be2a0d2a9c54263c43660990be", "commit_rev":
"fc930616af698875d2e6a2a955326c7910f4059a"}
Message was sent while issue was closed.
Description was changed from ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. Same as issue 721932. BUG=732574 R=hans@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== Disable NGLineBreakerTest.OverflowAtomicInline under ASan It leaks memory in CopyFragmentDataToLayoutBox. Disabling until LayoutNGPaintFragments is ready. Same as issue 721932. BUG=732574 R=hans@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2952143002 Cr-Commit-Position: refs/heads/master@{#481519} Committed: https://chromium.googlesource.com/chromium/src/+/fc930616af698875d2e6a2a95532... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fc930616af698875d2e6a2a95532...
Message was sent while issue was closed.
Why is it leaking? Wouldn't it be better to fix the leak than to disable the test?
Message was sent while issue was closed.
On 2017/06/22 at 17:28:54, cbiesinger wrote: > Why is it leaking? Wouldn't it be better to fix the leak than to disable the test? Can't agree more it's better, but I'm hoping we enable LayoutNGPaintFragments in a month or less. CopyFragmentDataToLayoutBox should be gone then. I acknowledge that CopyFragmentDataToLayoutBox is a hack and is not shippable, it's actually the reason why we decided we need to start LayoutNGPaintFragments project to eliminate it. We're very close to eliminate it now that I hope us to spend more time on it rather than on looking into CopyFragmentDataToLayoutBox.
Message was sent while issue was closed.
On 2017/06/23 06:07:35, kojii wrote: > On 2017/06/22 at 17:28:54, cbiesinger wrote: > > Why is it leaking? Wouldn't it be better to fix the leak than to disable the > test? > > Can't agree more it's better, but I'm hoping we enable LayoutNGPaintFragments in > a month or less. CopyFragmentDataToLayoutBox should be gone then. I acknowledge > that CopyFragmentDataToLayoutBox is a hack and is not shippable, it's actually > the reason why we decided we need to start LayoutNGPaintFragments project to > eliminate it. > > We're very close to eliminate it now that I hope us to spend more time on it > rather than on looking into CopyFragmentDataToLayoutBox. OK, sounds reasonable. Thanks. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
