third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc - Issue 2952143002: Disable NGLineBreakerTest.OverflowAtomicInline under ASan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

Issue 2952143002: Disable NGLineBreakerTest.OverflowAtomicInline under ASan (Closed)

Patch Set: fix typo Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

index 25cf38f058cc13abfa969836d862160aaa37143b..4761ba3facdb9913b09af90761389e741fbda8e8 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

@@ -109,7 +109,14 @@ TEST_F(NGLineBreakerTest, OverflowWord) {

EXPECT_EQ("678", ToString(lines[1], node));

}

-TEST_F(NGLineBreakerTest, OverflowAtomicInline) {

+// The test leaks memory in CopyFragmentDataToLayoutBox. Re-enable when

+// LayoutNGPaintFragments is ready. crbug.com/732574

+#if defined(ADDRESS_SANITIZER)

+#define MAYBE_OverflowAtomicInline DISABLED_OverflowAtomicInline

+#else

+#define MAYBE_OverflowAtomicInline OverflowAtomicInline

+#endif

+TEST_F(NGLineBreakerTest, MAYBE_OverflowAtomicInline) {

LoadAhem();

NGInlineNode node = CreateInlineNode(R"HTML(

<!DOCTYPE html>

« no previous file with comments | « no previous file | no next file » | no next file with comments »