Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2952093002: Rename SuperAnimationTimeline to AnimationTimeline (Closed)

Created:
3 years, 6 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, smcgruer
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SuperAnimationTimeline to AnimationTimeline Following on from https://codereview.chromium.org/2944423003 and https://codereview.chromium.org/2948193002, this patch completes the final cleanup by renaming the superclass from SuperAnimationTimeline to AnimationTimeline. BUG=624639 Review-Url: https://codereview.chromium.org/2952093002 Cr-Commit-Position: refs/heads/master@{#482864} Committed: https://chromium.googlesource.com/chromium/src/+/541199602915c21a9d41148cfe872951748dad69

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase + add missing header to AnimationTimeline.h #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/animation/AnimationTimeline.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimeline.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimeline.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/animation/SuperAnimationTimeline.h View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
suzyh_UTC10 (ex-contributor)
And here is patch 3 of 3.
3 years, 6 months ago (2017-06-22 00:51:43 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-22 01:20:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952093002/60001
3 years, 5 months ago (2017-06-28 00:20:48 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 03:04:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/541199602915c21a9d41148cfe87...

Powered by Google App Engine
This is Rietveld 408576698