Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2952083004: Change memory dumps to not use periodic dumps by default. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change memory dumps to not use periodic dumps by default. All consumers that require periodic dumps now explicitly specify a dump config. Remove by default the periodic dump config. BUG=726393 Review-Url: https://codereview.chromium.org/2952083004 Cr-Commit-Position: refs/heads/master@{#481951} Committed: https://chromium.googlesource.com/chromium/src/+/c72902d0a30ee1fc71e7890d14c9ca79c3d387b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/trace_event/trace_config.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
erikchen
primiano: Please review. Compared to https://codereview.chromium.org/2951413002/, we no longer need to modify content/browser/tracing/tracing_ui.cc since all ...
3 years, 6 months ago (2017-06-23 01:15:17 UTC) #5
Primiano Tucci (use gerrit)
LGTM assuming we land the UI changes first :) Thanks for fixing all this.
3 years, 6 months ago (2017-06-23 09:38:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952083004/1
3 years, 6 months ago (2017-06-23 17:47:23 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 17:53:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c72902d0a30ee1fc71e7890d14c9...

Powered by Google App Engine
This is Rietveld 408576698