Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: base/trace_event/memory_dump_manager_unittest.cc

Issue 2952083004: Change memory dumps to not use periodic dumps by default. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/trace_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager_unittest.cc
diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc
index 26a826b0b00ded6598055cb3fe52f60b18399d0b..903321c777b30e5545f92ebe2ab57ff13a6acd0c 100644
--- a/base/trace_event/memory_dump_manager_unittest.cc
+++ b/base/trace_event/memory_dump_manager_unittest.cc
@@ -891,17 +891,17 @@ TEST_F(MemoryDumpManagerTest, TraceConfigExpectationsWhenIsCoordinator) {
InitializeMemoryDumpManagerForInProcessTesting(true /* is_coordinator */);
// Enabling memory-infra with the legacy TraceConfig (category filter) in
- // a coordinator process should enable periodic dumps.
+ // a coordinator process should not enable periodic dumps.
EnableTracingWithLegacyCategories(MemoryDumpManager::kTraceCategory);
- EXPECT_TRUE(IsPeriodicDumpingEnabled());
+ EXPECT_FALSE(IsPeriodicDumpingEnabled());
DisableTracing();
// Enabling memory-infra with the new (JSON) TraceConfig in a coordinator
- // process without specifying any "memory_dump_config" section should enable
+ // process while specifying a "memory_dump_config" section should enable
// periodic dumps. This is to preserve the behavior chrome://tracing UI, that
- // is: ticking memory-infra should dump periodically with the default config.
+ // is: ticking memory-infra should dump periodically with an explicit config.
EnableTracingWithTraceConfig(
- TraceConfigMemoryTestUtil::GetTraceConfig_NoTriggers());
+ TraceConfigMemoryTestUtil::GetTraceConfig_PeriodicTriggers(100, 5));
EXPECT_TRUE(IsPeriodicDumpingEnabled());
DisableTracing();
« no previous file with comments | « no previous file | base/trace_event/trace_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698