Remove redundant canonicalization in LayoutSelection::CalacSelectionRange

Remove redundant canonicalization in LayoutSelection::CalacSelectionRange

Since we call CreateVisibleSelection just above, we don't need canonicalize
 again.

BUG=708453
Review-Url: https://codereview.chromium.org/2951893003
Cr-Commit-Position: refs/heads/master@{#481457}
Committed: https://chromium.googlesource.com/chromium/src/+/2e9c25f8d596ec955e3ff7667e6d10376466596a

[yoichio, 2017-06-21 07:37:30]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 07:37:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 09:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 09:41:36]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-06-22 01:43:42]

Description was changed from

==========
REmove redundant posiion move from CalacSelectionRange

BUG=
==========

to

==========
Remove redundant canonicalization in LayoutSelection::CalacSelectionRange

Since we call CreateVisibleSelection just above, we don't need canonicalize
 again.

BUG=708453
==========

[yoichio, 2017-06-22 01:43:43]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-06-22 02:08:40]

lgtm

Excellent!
Thanks for finding this! (^_^)b

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right):

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:342: 
nit: we don't need to have an extra blank line between
DCHECK(!seleciton.isNone()) and |const Position...|

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:345:
DCHECK(start_pos.IsNotNull());
nit: Could you remove this? DCHECK_LE() can crash with null position.
Also, we have DCHECK(!selection.IsNone()) at L314.

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:346:
DCHECK(end_pos.IsNotNull());
nit: Could you remove this? DCHECK_LE() can crash with null position.
Also, we have DCHECK(!selection.IsNone()) at L314.

[yoichio, 2017-06-22 03:49:14]

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right):

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:342: 
On 2017/06/22 02:08:40, yosin_UTC9 wrote:
> nit: we don't need to have an extra blank line between
> DCHECK(!seleciton.isNone()) and |const Position...|

Done.

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:345:
DCHECK(start_pos.IsNotNull());
On 2017/06/22 02:08:40, yosin_UTC9 wrote:
> nit: Could you remove this? DCHECK_LE() can crash with null position.
> Also, we have DCHECK(!selection.IsNone()) at L314.

Done.

https://codereview.chromium.org/2951893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:346:
DCHECK(end_pos.IsNotNull());
On 2017/06/22 02:08:40, yosin_UTC9 wrote:
> nit: Could you remove this? DCHECK_LE() can crash with null position.
> Also, we have DCHECK(!selection.IsNone()) at L314.

Done.

[yoichio, 2017-06-22 03:49:17]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-06-22 03:49:17]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2951893003/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-06-22 03:49:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498103357488290,
"parent_rev": "0f85fb2fc13f1d0e20dafd60f454725ef09d8635", "commit_rev":
"2e9c25f8d596ec955e3ff7667e6d10376466596a"}

[commit-bot: I haz the power, 2017-06-22 05:54:20]

Description was changed from

==========
Remove redundant canonicalization in LayoutSelection::CalacSelectionRange

Since we call CreateVisibleSelection just above, we don't need canonicalize
 again.

BUG=708453
==========

to

==========
Remove redundant canonicalization in LayoutSelection::CalacSelectionRange

Since we call CreateVisibleSelection just above, we don't need canonicalize
 again.

BUG=708453

Review-Url: https://codereview.chromium.org/2951893003
Cr-Commit-Position: refs/heads/master@{#481457}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e9c25f8d596ec955e3ff7667e6d...
==========

[commit-bot: I haz the power, 2017-06-22 05:54:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2e9c25f8d596ec955e3ff7667e6d...