Remove redundant canonicalization in LayoutSelection::CalacSelectionRange

third_party/WebKit/Source/core/editing/LayoutSelection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
  * reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 321 matching lines @@
   // <rdar://problem/10232866>.
   const SelectionInFlatTree& new_selection = CalcSelection(
       original_selection, frame_selection.ShouldShowBlockCursor());
   const VisibleSelectionInFlatTree& selection =
       CreateVisibleSelection(new_selection);
 
   if (!selection.IsRange() || frame_selection.IsHidden())
     return SelectionPaintRange();
 
   DCHECK(!selection.IsNone());
-  // Use the rightmost candidate for the start of the selection, and the
-  // leftmost candidate for the end of the selection. Example: foo <a>bar</a>.
-  // Imagine that a line wrap occurs after 'foo', and that 'bar' is selected.
-  // If we pass [foo, 3] as the start of the selection, the selection painting
-  // code will think that content on the line containing 'foo' is selected
-  // and will fill the gap before 'bar'.
-  PositionInFlatTree start_pos = selection.Start();
-  const PositionInFlatTree most_forward_start =
-      MostForwardCaretPosition(start_pos);
-  if (IsVisuallyEquivalentCandidate(most_forward_start))
-    start_pos = most_forward_start;
-  PositionInFlatTree end_pos = selection.End();
-  const PositionInFlatTree most_backward = MostBackwardCaretPosition(end_pos);
-  if (IsVisuallyEquivalentCandidate(most_backward))
-    end_pos = most_backward;
 

[yosin_UTC9, 2017/06/22 02:08:40]

nit: we don't need to have an extra blank line between
DCHECK(!seleciton.isNone()) and |const Position...|

[yoichio, 2017/06/22 03:49:14]

Done.

+  const PositionInFlatTree start_pos = selection.Start();
+  const PositionInFlatTree end_pos = selection.End();
   DCHECK(start_pos.IsNotNull());

[yosin_UTC9, 2017/06/22 02:08:40]

nit: Could you remove this? DCHECK_LE() can crash with null position.
Also, we have DCHECK(!selection.IsNone()) at L314.

[yoichio, 2017/06/22 03:49:14]

Done.

   DCHECK(end_pos.IsNotNull());

[yosin_UTC9, 2017/06/22 02:08:40]

nit: Could you remove this? DCHECK_LE() can crash with null position.
Also, we have DCHECK(!selection.IsNone()) at L314.

[yoichio, 2017/06/22 03:49:14]

Done.

   DCHECK_LE(start_pos, end_pos);
   LayoutObject* start_layout_object = start_pos.AnchorNode()->GetLayoutObject();
   LayoutObject* end_layout_object = end_pos.AnchorNode()->GetLayoutObject();
   DCHECK(start_layout_object);
   DCHECK(end_layout_object);
   DCHECK(start_layout_object->View() == end_layout_object->View());
 
   return SelectionPaintRange(start_layout_object,
                              start_pos.ComputeEditingOffset(),
                              end_layout_object, end_pos.ComputeEditingOffset());
@@ skipping 61 matching lines @@
 
     runner->SetShouldInvalidateSelection();
   }
 }
 
 DEFINE_TRACE(LayoutSelection) {
   visitor->Trace(frame_selection_);
 }
 
 }  // namespace blink