CSS Properties & Values API: replace transform-function with transform-list.

CSS Properties & Values API:replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-strings
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
Review-Url: https://codereview.chromium.org/2951763002
Cr-Commit-Position: refs/heads/master@{#481796}
Committed: https://chromium.googlesource.com/chromium/src/+/130694fb49bf9eea4094ad28f765626b947d4261

[Hwanseung Lee, 2017-06-20 14:34:30]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 14:34:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-06-20 15:11:29]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 15:11:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-06-20 15:24:20]

Description was changed from

==========
[custom-properties] implement to parsing with initalValue when transfrom type.

BUG=
==========

to

==========
[custom-properties] replace transform-function with transform-list.

transform-function of supported syntax strings is changed to 
transform-list.
<transform-list> is already a space separated list, <transform-list>+ is
invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=
==========

[Hwanseung Lee, 2017-06-20 15:24:41]

Patchset #2 (id:20001) has been deleted

[Hwanseung Lee, 2017-06-20 15:25:00]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 15:25:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-06-20 15:25:40]

Description was changed from

==========
[custom-properties] replace transform-function with transform-list.

transform-function of supported syntax strings is changed to 
transform-list.
<transform-list> is already a space separated list, <transform-list>+ is
invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=
==========

to

==========
[custom-properties] replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=
==========

[Hwanseung Lee, 2017-06-20 15:29:04]

Description was changed from

==========
[custom-properties] replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=
==========

to

==========
[custom-properties] replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

[Hwanseung Lee, 2017-06-20 15:30:25]

Description was changed from

==========
[custom-properties] replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

to

==========
CSS Properties & Values API: replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

[commit-bot: I haz the power, 2017-06-20 17:42:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 17:42:25]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-06-21 00:35:59]

hs1217.lee@samsung.com changed reviewers:
+ meade@chromium.org

[Hwanseung Lee, 2017-06-21 00:35:59]

@meade
PTAL, thank you.

[meade_UTC10, 2017-06-21 06:57:45]

This is really close.

https://codereview.chromium.org/2951763002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp (right):

https://codereview.chromium.org/2951763002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp:181:
CSSParserLocalContext());
I had a discussion with the team - and we decided that we shouldn't be calling
CSSPropertyAPITransform directly from here. 

All the other types call "utils" functions (that happen to be in
CSSPropertyParserHelpers) - so we decided that the transform parsing logic
should be moved into a new "CSSPropertyTransformUtils" file (something like
this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/prope...)
Then you can call that file from here.

[Hwanseung Lee, 2017-06-21 12:26:14]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 12:26:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 14:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 14:19:47]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-06-22 00:39:54]

https://codereview.chromium.org/2951763002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp (right):

https://codereview.chromium.org/2951763002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp:181:
CSSParserLocalContext());
On 2017/06/21 06:57:44, meade_UTC10 wrote:
> I had a discussion with the team - and we decided that we shouldn't be calling
> CSSPropertyAPITransform directly from here. 
> 
> All the other types call "utils" functions (that happen to be in
> CSSPropertyParserHelpers) - so we decided that the transform parsing logic
> should be moved into a new "CSSPropertyTransformUtils" file (something like
> this:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/prope...)
> Then you can call that file from here.

i made CSSPropertyTransformUtils files(it was copied from
CSSPropertyAPITransform. so almost same).
and then i added ConsumeTransformList function which use
CSSPropertyTransformUtils in CSSPropertyParserHelpers.
ConsumeTransformList function called in this line.
is it right which i understand?

[meade_UTC10, 2017-06-22 06:04:53]

Hi! Almost there - you just need to remove the logic from
CSSPropertyAPITransform and call your new utils functions from there instead.


here ->
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/prope...

[Hwanseung Lee, 2017-06-22 12:13:37]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 12:13:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-06-22 12:18:54]

Description was changed from

==========
CSS Properties & Values API: replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

to

==========
CSS Properties & Values API: replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform 

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

[Hwanseung Lee, 2017-06-22 12:19:45]

Description was changed from

==========
CSS Properties & Values API: replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform 

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

to

==========
CSS Properties & Values API:replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

[Hwanseung Lee, 2017-06-22 13:51:52]

On 2017/06/22 06:04:53, meade_UTC10 wrote:
> Hi! Almost there - you just need to remove the logic from
> CSSPropertyAPITransform and call your new utils functions from there instead.
> 
> 
> here ->
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/prope...

i fixed it. could you review again?

[commit-bot: I haz the power, 2017-06-22 14:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 14:25:44]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-06-22 23:20:43]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-06-22 23:20:44]

lgtm

[meade_UTC10, 2017-06-23 02:47:58]

lgtm

[Hwanseung Lee, 2017-06-23 02:53:38]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-06-23 02:54:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:10:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498186418746960,
"parent_rev": "f5d1ccf9b970077765c051b07aa0748c1feb0760", "commit_rev":
"3cc01d2703f9e2dc0e9a5fca898266d0e3d166fc"}

[commit-bot: I haz the power, 2017-06-23 03:11:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498186418746960,
"parent_rev": "068d8effdd833f52de537ced8cbfe8676daf19f6", "commit_rev":
"130694fb49bf9eea4094ad28f765626b947d4261"}

[commit-bot: I haz the power, 2017-06-23 03:11:15]

Description was changed from

==========
CSS Properties & Values API:replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877
==========

to

==========
CSS Properties & Values API:replace transform-function with transform-list.

transform-function is changed to transform-list.
<transform-list> is already a space separated list, 
so <transform-list>+ is invalid.
parsing functions for transform-form type were moved to
CSSPropertyTransformUtils from CSSPropertyAPITransform.

https://drafts.css-houdini.org/css-properties-values-api-1/#supported-syntax-...
https://github.com/w3c/css-houdini-drafts/issues/290

BUG=641877

Review-Url: https://codereview.chromium.org/2951763002
Cr-Commit-Position: refs/heads/master@{#481796}
Committed:
https://chromium.googlesource.com/chromium/src/+/130694fb49bf9eea4094ad28f765...
==========

[commit-bot: I haz the power, 2017-06-23 03:11:16]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/130694fb49bf9eea4094ad28f765...