CSS Properties & Values API: replace transform-function with transform-list.

third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/CSSSyntaxDescriptor.h"
 
 #include "core/animation/CSSColorInterpolationType.h"
 #include "core/animation/CSSLengthInterpolationType.h"
 #include "core/animation/CSSValueInterpolationType.h"
 #include "core/css/CSSCustomPropertyDeclaration.h"
 #include "core/css/CSSURIValue.h"
 #include "core/css/CSSValueList.h"
 #include "core/css/CSSVariableReferenceValue.h"
 #include "core/css/parser/CSSParserIdioms.h"
+#include "core/css/parser/CSSParserLocalContext.h"
 #include "core/css/parser/CSSPropertyParserHelpers.h"
 #include "core/css/parser/CSSVariableParser.h"
+#include "core/css/properties/CSSPropertyAPITransform.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 
 namespace blink {
 
 void ConsumeWhitespace(const String& string, size_t& offset) {
   while (IsHTMLSpace(string[offset]))
     offset++;
 }
 
 bool ConsumeCharacterAndWhitespace(const String& string,
@@ skipping 23 matching lines @@
   if (type == "url")
     return CSSSyntaxType::kUrl;
   if (type == "integer")
     return CSSSyntaxType::kInteger;
   if (type == "angle")
     return CSSSyntaxType::kAngle;
   if (type == "time")
     return CSSSyntaxType::kTime;
   if (type == "resolution")
     return CSSSyntaxType::kResolution;
-  if (type == "transform-function")
-    return CSSSyntaxType::kTransformFunction;
+  if (type == "transform-list")
+    return CSSSyntaxType::kTransformList;
   if (type == "custom-ident")
     return CSSSyntaxType::kCustomIdent;
   // Not an Ident, just used to indicate failure
   return CSSSyntaxType::kIdent;
 }
 
 bool ConsumeSyntaxType(const String& input,
                        size_t& offset,
                        CSSSyntaxType& type) {
   DCHECK_EQ(input[offset], '<');
@@ skipping 43 matching lines @@
       type = CSSSyntaxType::kIdent;
       success = ConsumeSyntaxIdent(input, offset, ident);
     }
 
     if (!success) {
       syntax_components_.clear();
       return;
     }
 
     bool repeatable = ConsumeCharacterAndWhitespace(input, '+', offset);
+    // <transform-list> is already a space separated list,
+    // <transform-list>+ is invalid.
+    if (type == CSSSyntaxType::kTransformList && repeatable) {
+      syntax_components_.clear();
+      return;
+    }
     ConsumeWhitespace(input, offset);
     syntax_components_.push_back(CSSSyntaxComponent(type, ident, repeatable));
 
   } while (ConsumeCharacterAndWhitespace(input, '|', offset));
 
   if (offset != input.length())
     syntax_components_.clear();
 }
 
 const CSSValue* ConsumeSingleType(const CSSSyntaxComponent& syntax,
@@ skipping 26 matching lines @@
     case CSSSyntaxType::kUrl:
       return ConsumeUrl(range, context);
     case CSSSyntaxType::kInteger:
       return ConsumeInteger(range);
     case CSSSyntaxType::kAngle:
       return ConsumeAngle(range, *context, WTF::Optional<WebFeature>());
     case CSSSyntaxType::kTime:
       return ConsumeTime(range, ValueRange::kValueRangeAll);
     case CSSSyntaxType::kResolution:
       return ConsumeResolution(range);
-    case CSSSyntaxType::kTransformFunction:
-      return nullptr;  // TODO(timloh): Implement this.
+    case CSSSyntaxType::kTransformList:
+      return CSSPropertyAPITransform::parseSingleValue(range, *context,
+                                                       CSSParserLocalContext());

[meade_UTC10, 2017/06/21 06:57:44]

I had a discussion with the team - and we decided that we shouldn't be calling
CSSPropertyAPITransform directly from here. 

All the other types call "utils" functions (that happen to be in
CSSPropertyParserHelpers) - so we decided that the transform parsing logic
should be moved into a new "CSSPropertyTransformUtils" file (something like
this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/prope...)
Then you can call that file from here.

[Hwanseung Lee, 2017/06/22 00:39:53]

i made CSSPropertyTransformUtils files(it was copied from
CSSPropertyAPITransform. so almost same).
and then i added ConsumeTransformList function which use
CSSPropertyTransformUtils in CSSPropertyParserHelpers.
ConsumeTransformList function called in this line.
is it right which i understand?

     case CSSSyntaxType::kCustomIdent:
       return ConsumeCustomIdent(range);
     default:
       NOTREACHED();
       return nullptr;
   }
 }
 
 const CSSValue* ConsumeSyntaxComponent(const CSSSyntaxComponent& syntax,
                                        CSSParserTokenRange range,
@@ skipping 26 matching lines @@
   for (const CSSSyntaxComponent& component : syntax_components_) {
     if (const CSSValue* result =
             ConsumeSyntaxComponent(component, range, context))
       return result;
   }
   return CSSVariableParser::ParseRegisteredPropertyValue(range, *context, true,
                                                          is_animation_tainted);
 }
 
 }  // namespace blink