Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2951683002: [milo] console -> frontend/console (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebse #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -151 lines) Patch
D milo/appengine/console/console.go View 1 1 chunk +0 lines, -108 lines 0 comments Download
D milo/appengine/console/html.go View 1 chunk +0 lines, -33 lines 0 comments Download
D milo/appengine/console/html_data.go View 1 chunk +0 lines, -12 lines 0 comments Download
A + milo/appengine/frontend/console/console.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/appengine/frontend/console/html.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/appengine/frontend/console/html_data.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M milo/appengine/frontend/main.go View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (17 generated)
iannucci
3 years, 6 months ago (2017-06-20 07:14:09 UTC) #1
Ryan Tseng
lgtm Add bug 735098
3 years, 6 months ago (2017-06-20 18:06:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951683002/40001
3 years, 6 months ago (2017-06-21 19:05:46 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 19:19:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/3cf51924441e66925474376419ab73e0e326acf7

Powered by Google App Engine
This is Rietveld 408576698