Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: milo/appengine/console/console.go

Issue 2951683002: [milo] console -> frontend/console (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/appengine/console/html.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/console/console.go
diff --git a/milo/appengine/console/console.go b/milo/appengine/console/console.go
deleted file mode 100644
index 11029f710773d06e41b49e3ef9438d3fb7805130..0000000000000000000000000000000000000000
--- a/milo/appengine/console/console.go
+++ /dev/null
@@ -1,108 +0,0 @@
-// Copyright 2016 The LUCI Authors. All rights reserved.
-// Use of this source code is governed under the Apache License, Version 2.0
-// that can be found in the LICENSE file.
-
-package console
-
-import (
- "fmt"
- "net/http"
- "strings"
-
- "golang.org/x/net/context"
-
- "github.com/luci/luci-go/common/clock"
- "github.com/luci/luci-go/common/logging"
- "github.com/luci/luci-go/server/router"
-
- "github.com/luci/luci-go/milo/api/config"
- "github.com/luci/luci-go/milo/api/resp"
- "github.com/luci/luci-go/milo/appengine/common"
- "github.com/luci/luci-go/milo/appengine/common/gitiles"
- "github.com/luci/luci-go/milo/appengine/job_source/buildbot"
-)
-
-// Returns results of build[commit_index][builder_index]
-func GetConsoleBuilds(
- c context.Context, module string,
- builders []resp.BuilderRef, commits []string) (
- [][]*resp.ConsoleBuild, error) {
-
- switch module {
- case "buildbot":
- return buildbot.GetConsoleBuilds(c, builders, commits)
- // The case for buildbucket and dm goes here.
- default:
- panic(fmt.Errorf("Unrecognized module %s", module))
- }
-}
-
-// getConsoleDef finds the console definition as defined by any project.
-// If the user is not a reader of the project, this will return a 404.
-// TODO(hinoka): If the user is not a reader of any of of the builders returned,
-// that builder will be removed from list of results.
-func getConsoleDef(c context.Context, project, name string) (*config.Console, error) {
- cs, err := common.GetConsole(c, project, name)
- if err != nil {
- return nil, err
- }
- // TODO(hinoka): Remove builders that the user does not have access to.
- return cs, nil
-}
-
-// Main is a redirect handler that redirects the user to the main console for a
-// particular project.
-func Main(ctx *router.Context) {
- w, r, p := ctx.Writer, ctx.Request, ctx.Params
- proj := p.ByName("project")
- http.Redirect(w, r, fmt.Sprintf("/console/%s/main", proj), http.StatusMovedPermanently)
- return
-}
-
-func console(c context.Context, project, name string) (*resp.Console, error) {
- tStart := clock.Now(c)
- def, err := getConsoleDef(c, project, name)
- if err != nil {
- return nil, err
- }
- commits, err := gitiles.GetCommits(c, def.RepoURL, def.Branch, 25)
- if err != nil {
- return nil, err
- }
- tGitiles := clock.Now(c)
- logging.Debugf(c, "Loading commits took %s.", tGitiles.Sub(tStart))
- commitNames := make([]string, len(commits))
- commitLinks := make([]*resp.Link, len(commits))
- for i, commit := range commits {
- commitNames[i] = commit.Revision.Label
- commitLinks[i] = commit.Revision
- }
-
- // HACK(hinoka): This only supports buildbot....
- builders := make([]resp.BuilderRef, len(def.Builders))
- for i, b := range def.Builders {
- builders[i] = resp.BuilderRef{
- b.Module, b.Name, strings.Split(b.Category, "|"), b.ShortName,
- }
- }
- cb, err := GetConsoleBuilds(c, "buildbot", builders, commitNames)
- tConsole := clock.Now(c)
- logging.Debugf(c, "Loading the console took a total of %s.", tConsole.Sub(tGitiles))
- if err != nil {
- return nil, err
- }
- ccb := make([]resp.CommitBuild, len(commits))
- for i, commit := range commitLinks {
- // TODO(hinoka): Not like this
- ccb[i].Commit = resp.Commit{Revision: commit}
- ccb[i].Build = cb[i]
- }
-
- cs := &resp.Console{
- Name: def.Name,
- Commit: ccb,
- BuilderRef: builders,
- }
-
- return cs, nil
-}
« no previous file with comments | « no previous file | milo/appengine/console/html.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698