[Night Light] CL9: Add localization for time's AM and PM

[Night Light] CL9: Add localization for time labels     

Adds localization for the custom schedule slider legend 
marker lebels, as well as the time bubbles.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2951483003
Cr-Commit-Position: refs/heads/master@{#480932}
Committed: https://chromium.googlesource.com/chromium/src/+/6981621888770efa9113d80998b3dc7fa345842e

[afakhry, 2017-06-19 23:27:45]

Description was changed from

==========
[Night Light] CL9: Add localization for time's AM and PM

Adds localization for AM and PM as well as localizes the
custom schedule slider legend marker lebels.

BUG=705816
==========

to

==========
[Night Light] CL9: Add localization for time's AM and PM

Adds localization for AM and PM as well as localizes the
custom schedule slider legend marker lebels.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-06-19 23:30:40]

afakhry@chromium.org changed reviewers:
+ stevenjb@chromium.org

[afakhry, 2017-06-19 23:30:41]

Steven, please review this change too. Thank you! :)

[stevenjb, 2017-06-20 00:36:43]

https://codereview.chromium.org/2951483003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/night_light_slider.js
(right):

https://codereview.chromium.org/2951483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/night_light_slider.js:223: return
hour + ':' + this.pad2_(minute) + ' ' + amPm;
Looking around, it seems like we should be using Date.toLocaleTimeString here
instead?

[afakhry, 2017-06-20 16:47:44]

https://codereview.chromium.org/2951483003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/night_light_slider.js
(right):

https://codereview.chromium.org/2951483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/night_light_slider.js:223: return
hour + ':' + this.pad2_(minute) + ' ' + amPm;
On 2017/06/20 00:36:43, stevenjb wrote:
> Looking around, it seems like we should be using Date.toLocaleTimeString here
> instead?

Oh Wow, I had no idea about this. Thank you very much! This is much easier.
Done.

[stevenjb, 2017-06-20 17:25:56]

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/night_light_slider.html
(right):

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/night_light_slider.html:156: <div
style="left: 100%;">$i18n{displayNightLightLegend6Pm}</div>
Rather than requiring translation of these strings, we could just provide
something like getHourLabel_(6, 'pm') or get24HourLabel(18);

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/night_light_slider.js
(right):

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/night_light_slider.js:205: var d =
new Date(Date.now());
I think this is the same as Date() ?

[afakhry, 2017-06-20 18:09:33]

Description was changed from

==========
[Night Light] CL9: Add localization for time's AM and PM

Adds localization for AM and PM as well as localizes the
custom schedule slider legend marker lebels.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Night Light] CL9: Add localization for time labels     

Adds localization for the custom schedule slider legend 
marker lebels, as well as the time bubbles.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-06-20 18:10:34]

I also updated the commit message and the CL description.

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/night_light_slider.html
(right):

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/night_light_slider.html:156: <div
style="left: 100%;">$i18n{displayNightLightLegend6Pm}</div>
On 2017/06/20 17:25:56, stevenjb wrote:
> Rather than requiring translation of these strings, we could just provide
> something like getHourLabel_(6, 'pm') or get24HourLabel(18);

Yes, thanks!
I used our existing offsetMinutesToTimeString_().

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/night_light_slider.js
(right):

https://codereview.chromium.org/2951483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/night_light_slider.js:205: var d =
new Date(Date.now());
On 2017/06/20 17:25:56, stevenjb wrote:
> I think this is the same as Date() ?

Done.

[stevenjb, 2017-06-20 18:16:06]

lgtm

https://codereview.chromium.org/2951483003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/night_light_slider.html
(right):

https://codereview.chromium.org/2951483003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/night_light_slider.html:152: <!--
6:00 PM == 18 * 60 = 1080 minutes from 00:00. -->
nit: We could avoid these comments with a well named helper function, but this
is fine too.

[afakhry, 2017-06-20 18:31:24]

https://codereview.chromium.org/2951483003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/night_light_slider.html
(right):

https://codereview.chromium.org/2951483003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/night_light_slider.html:152: <!--
6:00 PM == 18 * 60 = 1080 minutes from 00:00. -->
On 2017/06/20 18:16:06, stevenjb wrote:
> nit: We could avoid these comments with a well named helper function, but this
> is fine too.

Sounds good. I added a documented helper function.

[afakhry, 2017-06-20 18:43:49]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-06-20 18:43:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2951483003/#ps60001
(title: "Better helper function")

[commit-bot: I haz the power, 2017-06-20 18:44:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 20:24:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497984229180560,
"parent_rev": "72b1ef03add8afb2a00c41a9b327ba625a07e8c7", "commit_rev":
"6981621888770efa9113d80998b3dc7fa345842e"}

[commit-bot: I haz the power, 2017-06-20 20:24:20]

Description was changed from

==========
[Night Light] CL9: Add localization for time labels     

Adds localization for the custom schedule slider legend 
marker lebels, as well as the time bubbles.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Night Light] CL9: Add localization for time labels     

Adds localization for the custom schedule slider legend 
marker lebels, as well as the time bubbles.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2951483003
Cr-Commit-Position: refs/heads/master@{#480932}
Committed:
https://chromium.googlesource.com/chromium/src/+/6981621888770efa9113d80998b3...
==========

[commit-bot: I haz the power, 2017-06-20 20:24:22]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6981621888770efa9113d80998b3...