chrome/browser/resources/settings/device_page/night_light_slider.html - Issue 2951483003: [Night Light] CL9: Add localization for time's AM and PM

Side by Side Diff: chrome/browser/resources/settings/device_page/night_light_slider.html

Issue 2951483003: [Night Light] CL9: Add localization for time's AM and PM (Closed)

Patch Set: toLocaleTimeString() Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/device_page/night_light_slider.js » ('j') | chrome/browser/resources/settings/device_page/night_light_slider.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html><head>	1 <html><head>

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/html/i18n_behavior.html">	3 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior /iron-a11y-keys-behavior.html">

5 <link rel="import" href="../prefs/prefs_behavior.html">	5 <link rel="import" href="../prefs/prefs_behavior.html">

6 </head><body><dom-module id="night-light-slider">	6 </head><body><dom-module id="night-light-slider">

7 <template>	7 <template>

8 <style>	8 <style>

9 :host {	9 :host {

10 cursor: default;	10 cursor: default;

(...skipping 131 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142 <div id="startProgress" class="progress"></div>	142 <div id="startProgress" class="progress"></div>

143 </div>	143 </div>

144 <div id="markersContainer">	144 <div id="markersContainer">

145 </div>	145 </div>

146 <div id="startKnob" class="knob" tabindex="1" on-down="startDrag_"	146 <div id="startKnob" class="knob" tabindex="1" on-down="startDrag_"

147 on-up="endDrag_" on-track="continueDrag_"></div>	147 on-up="endDrag_" on-track="continueDrag_"></div>

148 <div id="endKnob" class="knob" tabindex="2" on-down="startDrag_"	148 <div id="endKnob" class="knob" tabindex="2" on-down="startDrag_"

149 on-up="endDrag_" on-track="continueDrag_"></div>	149 on-up="endDrag_" on-track="continueDrag_"></div>

150 </div>	150 </div>

151 <div id="legendContainer">	151 <div id="legendContainer">

152 <!-- TODO(afakhry): Check if these values need to be localized. -->	152 <div style="left: 0%;">$i18n{displayNightLightLegend6Pm}</div>

153 <div style="left: 0%;">6 PM</div>	153 <div style="left: 25%;">$i18n{displayNightLightLegend12Am}</div>

154 <div style="left: 25%;">12 AM</div>	154 <div style="left: 50%;">$i18n{displayNightLightLegend6Am}</div>

155 <div style="left: 50%;">6 AM</div>	155 <div style="left: 75%;">$i18n{displayNightLightLegend12Pm}</div>

156 <div style="left: 75%;">12 PM</div>	156 <div style="left: 100%;">$i18n{displayNightLightLegend6Pm}</div>
	stevenjb 2017/06/20 17:25:56 Rather than requiring translation of these strings Rather than requiring translation of these strings, we could just provide something like getHourLabel_(6, 'pm') or get24HourLabel(18); afakhry 2017/06/20 18:10:34 Yes, thanks! I used our existing offsetMinutesToTi Show quoted text On 2017/06/20 17:25:56, stevenjb wrote: > Rather than requiring translation of these strings, we could just provide > something like getHourLabel_(6, 'pm') or get24HourLabel(18); Yes, thanks! I used our existing offsetMinutesToTimeString_().
157 <div style="left: 100%;">6 PM</div>

158 </div>	157 </div>

159 </div>	158 </div>

160	159

161 </template>	160 </template>

162 </dom-module>	161 </dom-module>

163 <script src="night_light_slider.js"></script></body></html>	162 <script src="night_light_slider.js"></script></body></html>

OLD	NEW