Fix gn builds never being clean at symbol_level = 0

Fix gn builds never being clean at symbol_level = 0

Builds with symbol_level = 0 don't generate PDB files, and our gn files
mostly know about this. One exception was chrome.exe.pdb which was
unconditionally specified as an output. This fixes that to make that
output conditional on symbol_level != 0.

BUG=647525
Review-Url: https://codereview.chromium.org/2951413004
Cr-Commit-Position: refs/heads/master@{#482435}
Committed: https://chromium.googlesource.com/chromium/src/+/4d7f37267b37b01230f7cd91626d508eab281c9e

[brucedawson, 2017-06-23 23:28:16]

Description was changed from

==========
Fix gn builds never being clean at symbol_level = 0

Builds with symbol_level = 0 don't generate PDB files, and our gn files
mostly know about this. One exception was chrome.exe.pdb which was
unconditionally specified as an output. This fixes that to make that
output conditional on symbol_level != 0.

BUG=647525
==========

to

==========
Fix gn builds never being clean at symbol_level = 0

Builds with symbol_level = 0 don't generate PDB files, and our gn files
mostly know about this. One exception was chrome.exe.pdb which was
unconditionally specified as an output. This fixes that to make that
output conditional on symbol_level != 0.

BUG=647525
==========

[brucedawson, 2017-06-23 23:28:16]

brucedawson@chromium.org changed reviewers:
+ thakis@chromium.org

[brucedawson, 2017-06-23 23:28:22]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 23:28:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 01:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 01:04:05]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-06-26 18:37:23]

This fixes one issue with never-clean builds. The other fix is
crrev.com/2948363004. PTAL at this one.

[Nico, 2017-06-26 19:56:22]

lgtm

[brucedawson, 2017-06-26 20:24:59]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-06-26 20:25:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 22:27:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498508699868140, "parent_rev":
"d3171a33bb3bce1cd16f7120d521751ba49b9043", "commit_rev":
"4d7f37267b37b01230f7cd91626d508eab281c9e"}

[commit-bot: I haz the power, 2017-06-26 22:27:18]

Description was changed from

==========
Fix gn builds never being clean at symbol_level = 0

Builds with symbol_level = 0 don't generate PDB files, and our gn files
mostly know about this. One exception was chrome.exe.pdb which was
unconditionally specified as an output. This fixes that to make that
output conditional on symbol_level != 0.

BUG=647525
==========

to

==========
Fix gn builds never being clean at symbol_level = 0

Builds with symbol_level = 0 don't generate PDB files, and our gn files
mostly know about this. One exception was chrome.exe.pdb which was
unconditionally specified as an output. This fixes that to make that
output conditional on symbol_level != 0.

BUG=647525

Review-Url: https://codereview.chromium.org/2951413004
Cr-Commit-Position: refs/heads/master@{#482435}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d7f37267b37b01230f7cd91626d...
==========

[commit-bot: I haz the power, 2017-06-26 22:27:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d7f37267b37b01230f7cd91626d...