Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: chrome/BUILD.gn

Issue 2951413004: Fix gn builds never being clean at symbol_level = 0 (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 7024bd3852e70da2839796a73b488c6c6ea6a64f..1de5ec6b0de6b5e33494aa23c37b0e22c86400f3 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -52,8 +52,10 @@ if (is_win) {
]
outputs = [
"$root_out_dir/chrome.exe",
- "$root_out_dir/chrome.exe.pdb",
]
+ if (symbol_level != 0) {
+ outputs += [ "$root_out_dir/chrome.exe.pdb" ]
+ }
args = [
"-i",
rebase_path("$root_out_dir/initialexe", root_build_dir),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698