Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2951303002: [CrOS Tether] Move LocalDeviceDataProvider from //chromeos/components/tether to //components/crypta… (Closed)

Created:
3 years, 6 months ago by Kyle Horimoto
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hansberry
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Move LocalDeviceDataProvider from //chromeos/components/tether to //components/cryptauth. This functionality is not logically coupled to the Tether component and will be used in other CryptAuth-related projects. See a sample usage of this change as part of https://codereview.chromium.org/2953863002. BUG=672263 Review-Url: https://codereview.chromium.org/2951303002 Cr-Commit-Position: refs/heads/master@{#481753} Committed: https://chromium.googlesource.com/chromium/src/+/25e8d1bb8c7d7bb658b4c0abf90cfa0db8e9e54f

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -595 lines) Patch
M chromeos/components/tether/BUILD.gn View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chromeos/components/tether/ble_advertiser.h View 4 chunks +4 lines, -5 lines 0 comments Download
M chromeos/components/tether/ble_advertiser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/components/tether/ble_advertiser_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chromeos/components/tether/ble_connection_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/components/tether/ble_connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/components/tether/ble_scanner.h View 4 chunks +10 lines, -8 lines 0 comments Download
M chromeos/components/tether/ble_scanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/components/tether/ble_scanner_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chromeos/components/tether/initializer.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chromeos/components/tether/initializer.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
D chromeos/components/tether/local_device_data_provider.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chromeos/components/tether/local_device_data_provider.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D chromeos/components/tether/local_device_data_provider_unittest.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D chromeos/components/tether/mock_local_device_data_provider.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chromeos/components/tether/mock_local_device_data_provider.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M components/cryptauth/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
A + components/cryptauth/local_device_data_provider.h View 3 chunks +8 lines, -15 lines 0 comments Download
A + components/cryptauth/local_device_data_provider.cc View 3 chunks +6 lines, -10 lines 0 comments Download
A + components/cryptauth/local_device_data_provider_unittest.cc View 14 chunks +39 lines, -48 lines 0 comments Download
A + components/cryptauth/mock_local_device_data_provider.h View 3 chunks +9 lines, -16 lines 0 comments Download
A + components/cryptauth/mock_local_device_data_provider.cc View 4 chunks +5 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
Kyle Horimoto
3 years, 6 months ago (2017-06-22 19:02:25 UTC) #3
Ryan Hansberry
lgtm
3 years, 6 months ago (2017-06-22 20:26:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951303002/1
3 years, 6 months ago (2017-06-22 20:27:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/126289) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-22 20:30:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951303002/20001
3 years, 6 months ago (2017-06-22 20:34:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/323550)
3 years, 6 months ago (2017-06-22 23:37:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951303002/20001
3 years, 6 months ago (2017-06-22 23:44:29 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:57:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25e8d1bb8c7d7bb658b4c0abf90c...

Powered by Google App Engine
This is Rietveld 408576698