Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2953863002: [CrOS Tether] ProximityAuth WebUI improvement: show the local device's ID. (Closed)

Created:
3 years, 6 months ago by Kyle Horimoto
Modified:
3 years, 6 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] ProximityAuth WebUI improvement: show the local device's ID. Previously, there was a device ID section which was never actually updated, leading to confusion by dogfooders. With this change, it is actually shown in the WebUI page. BUG=672263 Review-Url: https://codereview.chromium.org/2953863002 Cr-Commit-Position: refs/heads/master@{#481788} Committed: https://chromium.googlesource.com/chromium/src/+/b01b9a7f83ad1ed8247f6b4c907996270e1ed611

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 2

Patch Set 3 : tengs@ comment. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M chrome/browser/signin/chrome_proximity_auth_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/chrome_proximity_auth_client.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/proximity_auth/mock_proximity_auth_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/proximity_auth_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M components/proximity_auth/webui/resources/proximity_auth.css View 1 chunk +4 lines, -0 lines 0 comments Download
M components/proximity_auth/webui/resources/proximity_auth.html View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/webui/resources/proximity_auth.js View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Kyle Horimoto
3 years, 6 months ago (2017-06-22 19:02:43 UTC) #2
Tim Song
lgtm https://codereview.chromium.org/2953863002/diff/20001/components/proximity_auth/webui/proximity_auth_webui_handler.cc File components/proximity_auth/webui/proximity_auth_webui_handler.cc (right): https://codereview.chromium.org/2953863002/diff/20001/components/proximity_auth/webui/proximity_auth_webui_handler.cc#newcode418 components/proximity_auth/webui/proximity_auth_webui_handler.cc:418: std::unique_ptr<base::Value> truncated_device_id = nit: truncated_local_device_id
3 years, 6 months ago (2017-06-22 23:22:36 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/2953863002/diff/20001/components/proximity_auth/webui/proximity_auth_webui_handler.cc File components/proximity_auth/webui/proximity_auth_webui_handler.cc (right): https://codereview.chromium.org/2953863002/diff/20001/components/proximity_auth/webui/proximity_auth_webui_handler.cc#newcode418 components/proximity_auth/webui/proximity_auth_webui_handler.cc:418: std::unique_ptr<base::Value> truncated_device_id = On 2017/06/22 23:22:36, Tim Song wrote: ...
3 years, 6 months ago (2017-06-22 23:26:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953863002/60001
3 years, 6 months ago (2017-06-23 01:08:27 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 02:14:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b01b9a7f83ad1ed8247f6b4c9079...

Powered by Google App Engine
This is Rietveld 408576698