Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 29513004: Make Array.prototype.pop throw if the last element is not configurable. (Closed)

Created:
7 years, 2 months ago by Yanagi
Modified:
7 years, 2 months ago
Reviewers:
Yang
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Make Array.prototype.pop throw if the last element is not configurable. Popping an element from an array should call [[Delete]] internal method and pass true as the second argument (ECMA-262/5.1/#sec-15.4.4.6). When the last element can't be deleted, throw a Type Error. Not throwing the error would result in endless loop in the following test. TEST=var a=[];Object.defineProperty(a,0,{});while(a.length)a.pop(); By the way fix another bug, or else i can't post any issues. "presubmit.py" throw a "missing a correct copyright header" on windows. Both the slash and the backslash are valid path separator on windows. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17346

Patch Set 1 : remove some unnecessary effect. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Yanagi
7 years, 2 months ago (2013-10-19 03:45:25 UTC) #1
Yang
On 2013/10/19 03:45:25, Yanagi wrote: LGTM. I'll land this after making sure that there is ...
7 years, 2 months ago (2013-10-23 08:25:47 UTC) #2
Yang
https://codereview.chromium.org/29513004/diff/30001/tools/presubmit.py File tools/presubmit.py (right): https://codereview.chromium.org/29513004/diff/30001/tools/presubmit.py#newcode295 tools/presubmit.py:295: for dir_part in os.path.dirname(file).replace(os.sep,'/').split('/'): I took the liberty to ...
7 years, 2 months ago (2013-10-23 08:25:54 UTC) #3
Yang
https://codereview.chromium.org/29513004/diff/30001/tools/presubmit.py File tools/presubmit.py (right): https://codereview.chromium.org/29513004/diff/30001/tools/presubmit.py#newcode295 tools/presubmit.py:295: for dir_part in os.path.dirname(file).replace(os.sep,'/').split('/'): On 2013/10/23 08:25:54, Yang wrote: ...
7 years, 2 months ago (2013-10-23 16:14:23 UTC) #4
Yang
7 years, 2 months ago (2013-10-23 16:19:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r17346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698