Make Array.prototype.pop throw if the last element is not configurable.

tools/presubmit.py

 #!/usr/bin/env python
 #
 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 274 matching lines @@
   RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c', 'SConscript',
       'SConstruct', '.status', '.gyp', '.gypi']
 
   # Overwriting the one in the parent class.
   def FindFilesIn(self, path):
     if os.path.exists(path+'/.git'):
       output = subprocess.Popen('git ls-files --full-name',
                                 stdout=PIPE, cwd=path, shell=True)
       result = []
       for file in output.stdout.read().split():
-        for dir_part in os.path.dirname(file).split(os.sep):
+        for dir_part in os.path.dirname(file).replace(os.sep,'/').split('/'):

[Yang, 2013/10/23 08:25:54]

I took the liberty to change this to .dirname(file).split(os.sep)

[Yang, 2013/10/23 16:14:23]

nvm this.

           if self.IgnoreDir(dir_part):
             break
         else:
           if self.IsRelevant(file) and not self.IgnoreFile(file):
             result.append(join(path, file))
       if output.wait() == 0:
         return result
     return super(SourceProcessor, self).FindFilesIn(path)
 
   def IsRelevant(self, name):
@@ skipping 120 matching lines @@
         "two empty lines between declarations check..."
   success = SourceProcessor().Run(workspace) and success
   if success:
     return 0
   else:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(Main())