tools/presubmit.py - Issue 29513004: Make Array.prototype.pop throw if the last element is not configurable. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(158)

My Issues | Starred Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 29513004: Make Array.prototype.pop throw if the last element is not configurable. (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: remove some unnecessary effect. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « src/array.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index 780dab9cf9e4c86e347dac5b382ab989268e6dc6..aa0f55894ff12052562c7565409ccfc967c701e8 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -292,7 +292,7 @@ class SourceProcessor(SourceFileProcessor):

stdout=PIPE, cwd=path, shell=True)

result = []

for file in output.stdout.read().split():

- for dir_part in os.path.dirname(file).split(os.sep):

+ for dir_part in os.path.dirname(file).replace(os.sep,'/').split('/'):

Yang 2013/10/23 08:25:54 I took the liberty to change this to .dirname(file

Yang 2013/10/23 16:14:23 nvm this.

if self.IgnoreDir(dir_part):

break

else:

« no previous file with comments | « src/array.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698