Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

Issue 2951213005: [LayoutNG] Support objects that are opaque to whitespace collapsing (Closed)
Patch Set: Cleanup and update -expected.txt's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
index 6751cb388595d7125467ea5f9413db518ed303d6..1abb199e154f001f6fd2bf0b4906ffc09d97cdc8 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
@@ -230,12 +230,12 @@ LayoutObject* NGInlineNode::CollectInlines(LayoutObject* start,
// Add floats and positioned objects in the same way as atomic inlines.
// Because these objects need positions, they will be handled in
// NGInlineLayoutAlgorithm.
- builder->Append(NGInlineItem::kFloating, kObjectReplacementCharacter,
- nullptr, node);
+ builder->AppendAsOpaqueToSpaceCollapsing(NGInlineItem::kFloating, nullptr,
+ node);
} else if (node->IsOutOfFlowPositioned()) {
- builder->Append(NGInlineItem::kOutOfFlowPositioned,
- kObjectReplacementCharacter, nullptr, node);
+ builder->AppendAsOpaqueToSpaceCollapsing(
+ NGInlineItem::kOutOfFlowPositioned, nullptr, node);
} else if (node->IsAtomicInlineLevel()) {
// For atomic inlines add a unicode "object replacement character" to

Powered by Google App Engine
This is Rietveld 408576698