[LayoutNG] Support objects that are opaque to whitespace collapsing

third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h
index 9f295706ea0b3e1cdb2b3afe22068a496810b9bc..9d0cc1b979edfcab53332c5483d9cc0f155c4c80 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h
@@ -63,10 +63,16 @@ class CORE_EXPORT NGInlineItemsBuilder {
               const ComputedStyle* = nullptr,
               LayoutObject* = nullptr);
 
-  // Append a non-character item.
-  void Append(NGInlineItem::NGInlineItemType,
-              const ComputedStyle* = nullptr,
-              LayoutObject* = nullptr);
+  // Append a character.
+  // The character is opaque to space collapsing; i.e., spaces before this
+  // character and after this character can collapse as if this character does
+  // not exist.
+  void AppendAsOpaqueToSpaceCollapsing(NGInlineItem::NGInlineItemType, UChar);

[eae, 2017/06/23 18:49:09]

These names are a little too verbose, how about shortening it to AppendOpaque?

Thanks for the great comments explaining exactly what these methods do!

+
+  // Append a non-character item that is opaque to space collapsing.
+  void AppendAsOpaqueToSpaceCollapsing(NGInlineItem::NGInlineItemType,
+                                       const ComputedStyle* = nullptr,
+                                       LayoutObject* = nullptr);
 
   // Append a Bidi control character, for LTR or RTL depends on the style.
   void AppendBidiControl(const ComputedStyle*, UChar ltr, UChar rtl);
@@ -112,12 +118,9 @@ class CORE_EXPORT NGInlineItemsBuilder {
   // This function determines whether to add the newline or ignore.
   void ProcessPendingNewline(const String&, const ComputedStyle*);
 
-  // Removes the collapsible space at the end of |text_| if exists.
-  void RemoveTrailingCollapsibleSpaceIfExists(unsigned*);
-  void RemoveTrailingCollapsibleSpace(unsigned*);
-
-  void RemoveTrailingCollapsibleNewlineIfNeeded(unsigned*,
-                                                const String&,
+  void RemoveTrailingCollapsibleSpaceIfExists();
+  void RemoveTrailingCollapsibleSpace(unsigned);
+  void RemoveTrailingCollapsibleNewlineIfNeeded(const String&,
                                                 unsigned,
                                                 const ComputedStyle*);