Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2951193002: ozone/drm: Only reuse ScanoutBuffers with compatible modifiers (Closed)

Created:
3 years, 6 months ago by Daniele Castagna
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

ozone/drm: Only reuse ScanoutBuffers with compatible modifiers Now that we have modifiers, we need to make sure that not just the format, but also the format modifer is compatible with the HardwareDisplayController where we want to use the buffer. Reland of 9947afe90294ff5ad902e2cc02f8064506f7f0a4. BUG=b/38217940 TEST=Plug in external monitor that supports same resolution as internal panel with mirror mode enabled Change-Id: I87c2590b556d5be7e99b7e43249c98e943324a03 Reviewed-on: https://chromium-review.googlesource.com/541778 Reviewed-by: Daniele Castagna <dcastagna@chromium.org>; Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>; Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#481251} Review-Url: https://codereview.chromium.org/2951193002 . Cr-Commit-Position: refs/branch-heads/3112@{#426} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/d1f168985795e62f8a19e23bbdec99499601768e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -24 lines) Patch
M ui/ozone/platform/drm/gpu/drm_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_buffer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_hardware_display_plane_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc View 2 chunks +22 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc View 1 chunk +10 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/scanout_buffer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 4 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniele Castagna
3 years, 6 months ago (2017-06-21 21:51:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1f168985795e62f8a19e23bbdec99499601768e.

Powered by Google App Engine
This is Rietveld 408576698