Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2951073002: CANCELED: Make ComputeNodeBeforePosition() to return const Node* (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CANCELED I change mind. Please ignore this. Make ComputeNodeBeforePosition() to return const Node* This patch changes |Position::ComputeNodeBeforePosition()| to return |const Node*| instead of |Node*| as a preparation of [1]. [1] http://crbug.com/735327 Position should hold const Node instead of Node BUG=734849 TEST=n/a; no behavior changes

Patch Set 1 : 2017-06-21T17:59:27 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (8 generated)
yosin_UTC9
3 years, 6 months ago (2017-06-21 09:36:16 UTC) #5
PTAL

Including core/editing/ and core/html/

Powered by Google App Engine
This is Rietveld 408576698