Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 2951073002: CANCELED: Make ComputeNodeBeforePosition() to return const Node* (Closed)
Patch Set: 2017-06-21T17:59:27 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/Position.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 // - BeforeChildren 0 129 // - BeforeChildren 0
130 // - BeforeAnchor 0 130 // - BeforeAnchor 0
131 // - AfterChildren last editing offset in anchor node 131 // - AfterChildren last editing offset in anchor node
132 // - AfterAnchor last editing offset in anchor node 132 // - AfterAnchor last editing offset in anchor node
133 // Editing operations will change in anchor node rather than nodes around 133 // Editing operations will change in anchor node rather than nodes around
134 // anchor node. 134 // anchor node.
135 int ComputeEditingOffset() const; 135 int ComputeEditingOffset() const;
136 136
137 // These are convenience methods which are smart about whether the position is 137 // These are convenience methods which are smart about whether the position is
138 // neighbor anchored or parent anchored 138 // neighbor anchored or parent anchored
139 Node* ComputeNodeBeforePosition() const; 139 const Node* ComputeNodeBeforePosition() const;
140 Node* ComputeNodeAfterPosition() const; 140 Node* ComputeNodeAfterPosition() const;
141 141
142 // Returns node as |Range::firstNode()|. This position must be a 142 // Returns node as |Range::firstNode()|. This position must be a
143 // |PositionAnchorType::OffsetInAhcor| to behave as |Range| boundary point. 143 // |PositionAnchorType::OffsetInAhcor| to behave as |Range| boundary point.
144 Node* NodeAsRangeFirstNode() const; 144 Node* NodeAsRangeFirstNode() const;
145 145
146 // Similar to |nodeAsRangeLastNode()|, but returns a node in a range. 146 // Similar to |nodeAsRangeLastNode()|, but returns a node in a range.
147 Node* NodeAsRangeLastNode() const; 147 Node* NodeAsRangeLastNode() const;
148 148
149 // Returns a node as past last as same as |Range::pastLastNode()|. This 149 // Returns a node as past last as same as |Range::pastLastNode()|. This
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 283
284 } // namespace blink 284 } // namespace blink
285 285
286 #ifndef NDEBUG 286 #ifndef NDEBUG
287 // Outside the WebCore namespace for ease of invocation from gdb. 287 // Outside the WebCore namespace for ease of invocation from gdb.
288 void showTree(const blink::Position&); 288 void showTree(const blink::Position&);
289 void showTree(const blink::Position*); 289 void showTree(const blink::Position*);
290 #endif 290 #endif
291 291
292 #endif // Position_h 292 #endif // Position_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698