Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2950743002: Revert of Generate enum/getters/setters/mappings for flex-direction (Closed)

Created:
3 years, 6 months ago by hayato
Modified:
3 years, 6 months ago
Reviewers:
nainar, shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate enum/getters/setters/mappings for flex-direction (patchset #2 id:20001 of https://codereview.chromium.org/2942393002/ ) Reason for revert: Build break on "WebKit Mac Builder" https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/builds/209854 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac_Builder%2F209854%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout e.g. FAILED: blink_heap_unittests Undefined symbols for architecture x86_64: "blink::getJSPropertyName(blink::CSSPropertyID)", referenced from: blink::V8CSSStyleDeclaration::namedPropertyEnumeratorCustom(v8::PropertyCallbackInfo<v8::Array> const&) in libcore_generated.a(V8CSSStyleDeclarationCustom.o) "blink::cssPropertyID(WTF::String const&)", referenced from: blink::CSSComputedStyleDeclaration::getPropertyValue(WTF::String const&) in libcss_0.a(CSSComputedStyleDeclaration.o) Original issue's description: > Generate enum/getters/setters/mappings for flex-direction > > Currently, the flex-direction property is a 'storage_only' field, so > it has no generated public getters/setters. > > This patch changes it to a 'keyword' field so that its getters/setters > can be generated as well. We also generate the EFlexDirection enum and > use the generated CSSValueID <-> EFlexDirection mappings. > > Diff: https://gist.github.com/eeb4122cc02ef70ffa09c642cbc86458/revisions > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2942393002 > Cr-Commit-Position: refs/heads/master@{#480688} > Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d0cd6c8d72a00 TBR=nainar@chromium.org,shend@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628043 Review-Url: https://codereview.chromium.org/2950743002 Cr-Commit-Position: refs/heads/master@{#480704} Committed: https://chromium.googlesource.com/chromium/src/+/d09e98704771dd9a57e4a44401440871f0f582cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hayato
Created Revert of Generate enum/getters/setters/mappings for flex-direction
3 years, 6 months ago (2017-06-20 03:14:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950743002/1
3 years, 6 months ago (2017-06-20 03:14:36 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 03:15:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d09e98704771dd9a57e4a4440144...

Powered by Google App Engine
This is Rietveld 408576698