Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2950603003: Minor refactor to get rid of a friend association (Closed)

Created:
3 years, 6 months ago by Raj
Modified:
3 years, 6 months ago
Reviewers:
rajendrant, tbansal1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor refactor to get rid of a friend association Removes DataUse as a friend of DataUseAscriber. Improves ChromeDataUseAscriber by making repeated code to a private function. BUG=733417 Review-Url: https://codereview.chromium.org/2950603003 Cr-Commit-Position: refs/heads/master@{#480950} Committed: https://chromium.googlesource.com/chromium/src/+/510566d5056c8b71c2ede25e6509c3186d762590

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -51 lines) Patch
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.h View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc View 3 chunks +15 lines, -20 lines 0 comments Download
M components/data_use_measurement/core/data_use.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/data_use_measurement/core/data_use.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_recorder.h View 1 chunk +1 line, -13 lines 0 comments Download
M components/data_use_measurement/core/data_use_recorder.cc View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rajendrant
ptal
3 years, 6 months ago (2017-06-20 01:11:37 UTC) #2
tbansal1
lgtm % nit. https://codereview.chromium.org/2950603003/diff/1/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h File chrome/browser/data_use_measurement/chrome_data_use_ascriber.h (right): https://codereview.chromium.org/2950603003/diff/1/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h#newcode156 chrome/browser/data_use_measurement/chrome_data_use_ascriber.h:156: DataUseRecorderEntry recorder); s/recorder/entry/ for consistency with ...
3 years, 6 months ago (2017-06-20 18:06:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950603003/1
3 years, 6 months ago (2017-06-20 19:21:54 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:47:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/510566d5056c8b71c2ede25e6509...

Powered by Google App Engine
This is Rietveld 408576698