Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: components/data_use_measurement/core/data_use_recorder.h

Issue 2950603003: Minor refactor to get rid of a friend association (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_recorder.h
diff --git a/components/data_use_measurement/core/data_use_recorder.h b/components/data_use_measurement/core/data_use_recorder.h
index 9cebd99590accafd7b446550ed68d20ade416242..8bd1514d6a040d34bb002829113f0a9e7c72b0c4 100644
--- a/components/data_use_measurement/core/data_use_recorder.h
+++ b/components/data_use_measurement/core/data_use_recorder.h
@@ -64,25 +64,13 @@ class DataUseRecorder {
// Merge another DataUseRecorder to this instance.
void MergeFrom(DataUseRecorder* other);
- private:
- friend class DataUseAscriber;
-
- // Methods for tracking data use sources. These sources can initiate
- // URLRequests directly or indirectly. The entity whose data use is being
- // tracked by this recorder may comprise of sub-entities each of which use
- // network data. These helper methods help track these sub-entities.
- // A recorder will not be marked as having completed data use as long as it
- // has pending data sources.
- void AddPendingDataSource(void* source);
- bool HasPendingDataSource(void* source);
- void RemovePendingDataSource(void* source);
-
// Network Delegate methods:
void OnBeforeUrlRequest(net::URLRequest* request);
void OnUrlRequestDestroyed(net::URLRequest* request);
void OnNetworkBytesSent(net::URLRequest* request, int64_t bytes_sent);
void OnNetworkBytesReceived(net::URLRequest* request, int64_t bytes_received);
+ private:
// Pending URLRequests whose data is being tracked by this DataUseRecorder.
base::hash_set<net::URLRequest*> pending_url_requests_;

Powered by Google App Engine
This is Rietveld 408576698