Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2950583002: Check for the default search engine being null before using. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Check for the default search engine being null before using. It is valid for the DSE to be null if DefaultSearchProviderEnabled is false in the policy (see chrome://policy). Check and appropriately handle null in all cases. TEST=1.) Set "DefaultSearchProviderEnabled": false 2.) Go to settings, 3.) search engine marked as managed, disabled, and empty TEST=1.) Set "DefaultSearchProviderEnabled": true, "DefaultSearchProviderSearchURL": "http://www.google.com/?q={searchTerms}", "DefaultSearchProviderKeyword": "google" 2.) Go to settings 3.) search engine marked as managed, disabled, show google BUG=720504 Review-Url: https://codereview.chromium.org/2938403002 Cr-Original-Commit-Position: refs/heads/master@{#480234} Review-Url: https://codereview.chromium.org/2950583002 . Cr-Commit-Position: refs/branch-heads/3112@{#390} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/3950ed79b024d9b541f17b89f523be392c91d5d4

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 6 months ago (2017-06-19 20:06:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3950ed79b024d9b541f17b89f523be392c91d5d4.

Powered by Google App Engine
This is Rietveld 408576698