Check for the default search engine being null before using.

Check for the default search engine being null before using.

It is valid for the DSE to be null if DefaultSearchProviderEnabled
is false in the policy (see chrome://policy).

Check and appropriately handle null in all cases.

TEST=1.) Set "DefaultSearchProviderEnabled": false
     2.) Go to settings,
     3.) search engine marked as managed, disabled, and empty
TEST=1.) Set "DefaultSearchProviderEnabled": true,
         "DefaultSearchProviderSearchURL": "http://www.google.com/?q={searchTerms}",
         "DefaultSearchProviderKeyword": "google"
     2.) Go to settings
     3.) search engine marked as managed, disabled, show google

BUG=720504
Review-Url: https://codereview.chromium.org/2938403002
Cr-Commit-Position: refs/heads/master@{#480234}
Committed: https://chromium.googlesource.com/chromium/src/+/9c436a9669b2a3bc5cd10d8d75488715c8bf86aa

[Ted C, 2017-06-16 16:18:05]

tedchoc@chromium.org changed reviewers:
+ pkasting@chromium.org, twellington@chromium.org

[Ted C, 2017-06-16 16:18:06]

PTAL

pkasting - components/search_engines - Comment change only
twellington - *android*

[Theresa, 2017-06-16 16:35:55]

lgtm

[Peter Kasting, 2017-06-16 22:51:34]

LGTM

https://codereview.chromium.org/2938403002/diff/1/components/search_engines/t...
File components/search_engines/template_url_service.h (right):

https://codereview.chromium.org/2938403002/diff/1/components/search_engines/t...
components/search_engines/template_url_service.h:260: // NOTE: This may return
NULL in certain circumstances such as:
Nit: NULL -> null

https://codereview.chromium.org/2938403002/diff/1/components/search_engines/t...
components/search_engines/template_url_service.h:262: //       2.) Default
search engines are disabled by policy.
Nit: "The default search engine is disabled by policy"?

[Ted C, 2017-06-16 22:56:49]

https://codereview.chromium.org/2938403002/diff/1/components/search_engines/t...
File components/search_engines/template_url_service.h (right):

https://codereview.chromium.org/2938403002/diff/1/components/search_engines/t...
components/search_engines/template_url_service.h:260: // NOTE: This may return
NULL in certain circumstances such as:
On 2017/06/16 22:51:34, Peter Kasting wrote:
> Nit: NULL -> null

Done.

https://codereview.chromium.org/2938403002/diff/1/components/search_engines/t...
components/search_engines/template_url_service.h:262: //       2.) Default
search engines are disabled by policy.
On 2017/06/16 22:51:34, Peter Kasting wrote:
> Nit: "The default search engine is disabled by policy"?

Done.

[Ted C, 2017-06-16 22:56:57]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-06-16 22:56:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2938403002/#ps40001
(title: "Update comments")

[commit-bot: I haz the power, 2017-06-16 22:57:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 00:12:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497653817153460,
"parent_rev": "67aabe00c117998937559c4847d85451abe8450b", "commit_rev":
"9c436a9669b2a3bc5cd10d8d75488715c8bf86aa"}

[commit-bot: I haz the power, 2017-06-17 00:12:53]

Description was changed from

==========
Check for the default search engine being null before using.

It is valid for the DSE to be null if DefaultSearchProviderEnabled
is false in the policy (see chrome://policy).

Check and appropriately handle null in all cases.

TEST=1.) Set "DefaultSearchProviderEnabled": false
     2.) Go to settings,
     3.) search engine marked as managed, disabled, and empty
TEST=1.) Set "DefaultSearchProviderEnabled": true,
         "DefaultSearchProviderSearchURL":
"http://www.google.com/?q={searchTerms}",
         "DefaultSearchProviderKeyword": "google"
     2.) Go to settings
     3.) search engine marked as managed, disabled, show google

BUG=720504
==========

to

==========
Check for the default search engine being null before using.

It is valid for the DSE to be null if DefaultSearchProviderEnabled
is false in the policy (see chrome://policy).

Check and appropriately handle null in all cases.

TEST=1.) Set "DefaultSearchProviderEnabled": false
     2.) Go to settings,
     3.) search engine marked as managed, disabled, and empty
TEST=1.) Set "DefaultSearchProviderEnabled": true,
         "DefaultSearchProviderSearchURL":
"http://www.google.com/?q={searchTerms}",
         "DefaultSearchProviderKeyword": "google"
     2.) Go to settings
     3.) search engine marked as managed, disabled, show google

BUG=720504

Review-Url: https://codereview.chromium.org/2938403002
Cr-Commit-Position: refs/heads/master@{#480234}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c436a9669b2a3bc5cd10d8d7548...
==========

[commit-bot: I haz the power, 2017-06-17 00:12:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9c436a9669b2a3bc5cd10d8d7548...