Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2950563003: [milo] buildinfo -> rpc (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : actually include things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -63 lines) Patch
D milo/appengine/buildinfo/service.go View 1 chunk +0 lines, -56 lines 0 comments Download
M milo/appengine/frontend/main.go View 2 chunks +2 lines, -2 lines 0 comments Download
A + milo/appengine/rpc/buildinfo.go View 1 2 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
iannucci
3 years, 6 months ago (2017-06-20 01:39:32 UTC) #1
Ryan Tseng
lgtm Add bug: 735098
3 years, 6 months ago (2017-06-20 17:30:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950563003/20001
3 years, 6 months ago (2017-06-20 18:18:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950563003/20001
3 years, 6 months ago (2017-06-20 18:21:18 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 18:28:03 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/8633317accf225c46c29f8cd3b12bfaff06f3f04

Powered by Google App Engine
This is Rietveld 408576698