Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2952473003: [milo] mv backend/git/gitiles -> common/gitiles (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -134 lines) Patch
D milo/appengine/backend/git/gitiles.go View 1 chunk +0 lines, -124 lines 0 comments Download
A + milo/appengine/common/gitiles/gitiles.go View 1 3 chunks +8 lines, -8 lines 0 comments Download
M milo/appengine/console/console.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
iannucci
3 years, 6 months ago (2017-06-20 01:33:46 UTC) #1
Ryan Tseng
at some point this'll be a generic git interface if we do git ingestion and ...
3 years, 6 months ago (2017-06-20 01:37:17 UTC) #5
estaab
lgtm https://codereview.chromium.org/2952473003/diff/1/milo/appengine/backend/git/gitiles.go File milo/appengine/backend/git/gitiles.go (left): https://codereview.chromium.org/2952473003/diff/1/milo/appengine/backend/git/gitiles.go#oldcode36 milo/appengine/backend/git/gitiles.go:36: type Commiter struct { s/Commiter/Committer/
3 years, 6 months ago (2017-06-20 01:55:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952473003/20001
3 years, 6 months ago (2017-06-20 07:20:53 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 07:26:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/cd725e36e717e0bafb77a1972e8e2349067c2749

Powered by Google App Engine
This is Rietveld 408576698