chrome/common/extensions/permissions/chrome_permission_message_provider.cc - Issue 2950203002: Add new permission string for extensions that override new tab pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

Issue 2950203002: Add new permission string for extensions that override new tab pages. (Closed)

Patch Set: Devlin's last feedback. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/chrome_manifest_url_handlers.cc ('k') | chrome/common/extensions/permissions/chrome_permission_message_rules.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

index d0afe3b48e94fab4add79084513a43864ea51156..50175df33d4a599ba2a73e2440c2b95ff2ae874e 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

@@ -195,6 +195,12 @@ bool ChromePermissionMessageProvider::IsAPIOrManifestPrivilegeIncrease(

DropPermissionParameter(id, &new_ids);

}

+ // For M62, we added a new permission ID for new tab page overrides. Consider

+ // the addition of this permission to not result in a privilege increase for

+ // the time being.

+ // TODO(robertshield): Remove this once most of the population is on M62+

+ new_ids.erase(APIPermission::kNewTabPageOverride);

// If all the IDs were already there, it's not a privilege increase.

if (old_ids.Includes(new_ids))

return false;