Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3710)

Unified Diff: chrome/common/extensions/chrome_manifest_url_handlers.cc

Issue 2950203002: Add new permission string for extensions that override new tab pages. (Closed)
Patch Set: Devlin's last feedback. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/chrome_manifest_url_handlers.cc
diff --git a/chrome/common/extensions/chrome_manifest_url_handlers.cc b/chrome/common/extensions/chrome_manifest_url_handlers.cc
index cb6a0e9ec4858eded4e6eef20d342745f053640b..59238d89b794816a1eb4155b0f4bdf16b32bdf1b 100644
--- a/chrome/common/extensions/chrome_manifest_url_handlers.cc
+++ b/chrome/common/extensions/chrome_manifest_url_handlers.cc
@@ -142,8 +142,16 @@ bool URLOverridesHandler::Parse(Extension* extension, base::string16* error) {
*error = base::ASCIIToUTF16(errors::kMultipleOverrides);
return false;
}
+
+ // If this is an NTP override extension, add the NTP override permission.
+ if (url_overrides->chrome_url_overrides_.count(chrome::kChromeUINewTabHost)) {
+ PermissionsParser::AddAPIPermission(extension,
+ APIPermission::kNewTabPageOverride);
+ }
+
extension->SetManifestData(keys::kChromeURLOverrides,
std::move(url_overrides));
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698