chrome/common/extensions/permissions/chrome_permission_message_rules.cc - Issue 2950203002: Add new permission string for extensions that override new tab pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 2950203002: Add new permission string for extensions that override new tab pages. (Closed)

Patch Set: Devlin's last feedback. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_permission_message_provider.cc ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

index 285668db23ee98a144bd6fc2917ec4c1ecd54308..94cbbc68c5d0d3198b0fa5264e43149c83ba01cb 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

@@ -378,6 +378,12 @@ ChromePermissionMessageRule::GetAllRules() {

{APIPermission::kHostReadOnly},

{}},

+ // New tab page permission is fairly highly used so rank it quite highly.

+ // Nothing should subsume it.

+ {IDS_EXTENSION_PROMPT_WARNING_NEW_TAB_PAGE_OVERRIDE,

+ {APIPermission::kNewTabPageOverride},

+ {}},

// History-related permission messages.

// History already allows reading favicons, tab access and accessing the

// list of most frequently visited sites.