Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/browser/extensions/permission_message_combinations_unittest.cc

Issue 2950203002: Add new permission string for extensions that override new tab pages. (Closed)
Patch Set: Devlin's last feedback. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/permission_message_combinations_unittest.cc
diff --git a/chrome/browser/extensions/permission_message_combinations_unittest.cc b/chrome/browser/extensions/permission_message_combinations_unittest.cc
index 0adaffca82854183cd7b98768760833a29b35eed..f2f3d00946c49cdccf9bc0741a542b77c1719e84 100644
--- a/chrome/browser/extensions/permission_message_combinations_unittest.cc
+++ b/chrome/browser/extensions/permission_message_combinations_unittest.cc
@@ -1187,6 +1187,19 @@ TEST_F(PermissionMessageCombinationsUnittest, ClipboardPermissionMessages) {
CheckManifestProducesPermissions("Modify data you copy and paste"));
}
+TEST_F(PermissionMessageCombinationsUnittest, NewTabPagePermissionMessages) {
+ const char kManifest[] =
+ "{"
+ " 'chrome_url_overrides': {"
+ " 'newtab': 'newtab.html'"
+ " }"
+ "}";
+
+ CreateAndInstall(kManifest);
+ ASSERT_TRUE(CheckManifestProducesPermissions(
+ "Replace the page you see when opening a new tab"));
+}
+
// TODO(sashab): Add a test that checks that messages are generated correctly
// for withheld permissions, when an app is granted the 'all sites' permission.
« no previous file with comments | « chrome/browser/extensions/extension_loading_browsertest.cc ('k') | chrome/common/extensions/chrome_manifest_url_handlers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698