Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/edk/test/multiprocess_test_helper.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Fix Mojo launcher, review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/browser_watcher/window_hang_monitor_win_unittest.cc ('K') | « headless/lib/browser/headless_content_browser_client.cc ('k') | net/test/spawned_test_server/local_test_server_posix.cc » ('j') | net/test/spawned_test_server/local_test_server_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/test/multiprocess_test_helper.cc
diff --git a/mojo/edk/test/multiprocess_test_helper.cc b/mojo/edk/test/multiprocess_test_helper.cc
index ed96e1d0e98d1befca0a13f9f9bae9a1fed98ecb..75700cecc0d6c2790f0937b0ba8a8e163eec8d2b 100644
--- a/mojo/edk/test/multiprocess_test_helper.cc
+++ b/mojo/edk/test/multiprocess_test_helper.cc
@@ -135,13 +135,10 @@ ScopedMessagePipeHandle MultiprocessTestHelper::StartChildWithExtraSwitch(
base::LaunchOptions options;
#if defined(OS_POSIX)
- options.fds_to_remap = &handle_passing_info;
+ options.fds_to_remap = handle_passing_info;
#elif defined(OS_WIN)
options.start_hidden = true;
- if (base::win::GetVersion() >= base::win::VERSION_VISTA)
- options.handles_to_inherit = &handle_passing_info;
- else
- options.inherit_handles = true;
+ options.inherit_mode = base::LaunchOptions::Inherit::kAll;
jschuh 2017/07/24 19:41:27 Why is this one not using the inheritance list?
brettw 2017/07/24 23:35:30 Thanks!
#else
#error "Not supported yet."
#endif
« components/browser_watcher/window_hang_monitor_win_unittest.cc ('K') | « headless/lib/browser/headless_content_browser_client.cc ('k') | net/test/spawned_test_server/local_test_server_posix.cc » ('j') | net/test/spawned_test_server/local_test_server_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698