Improve process launch handle sharing API.

mojo/edk/test/multiprocess_test_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/test/multiprocess_test_helper.h"
 
 #include <functional>
 #include <set>
 #include <utility>
 
@@ skipping 117 matching lines @@
   if (!switch_string.empty()) {
     CHECK(!command_line.HasSwitch(switch_string));
     if (!switch_value.empty())
       command_line.AppendSwitchASCII(switch_string, switch_value);
     else
       command_line.AppendSwitch(switch_string);
   }
 
   base::LaunchOptions options;
 #if defined(OS_POSIX)
-  options.fds_to_remap = &handle_passing_info;
+  options.fds_to_remap = handle_passing_info;
 #elif defined(OS_WIN)
   options.start_hidden = true;
-  if (base::win::GetVersion() >= base::win::VERSION_VISTA)
-    options.handles_to_inherit = &handle_passing_info;
-  else
-    options.inherit_handles = true;
+  options.inherit_mode = base::LaunchOptions::Inherit::kAll;

[jschuh, 2017/07/24 19:41:27]

Why is this one not using the inheritance list?

[brettw, 2017/07/24 23:35:30]

Thanks!

 #else
 #error "Not supported yet."
 #endif
 
   // NOTE: In the case of named pipes, it's important that the server handle be
   // created before the child process is launched; otherwise the server binding
   // the pipe path can race with child's connection to the pipe.
   ScopedPlatformHandle server_handle;
   if (launch_type == LaunchType::CHILD || launch_type == LaunchType::PEER) {
     server_handle = channel.PassServerHandle();
@@ skipping 107 matching lines @@
       },
       true /* pass_pipe_ownership_to_main */);
 }
 
 // static
 mojo::ScopedMessagePipeHandle MultiprocessTestHelper::primordial_pipe;
 
 }  // namespace test
 }  // namespace edk
 }  // namespace mojo